From: Dave <dave.jiang@gmail.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Jeremy Higdon <jeremy@sgi.com>, linux-ide@vger.kernel.org
Subject: Re: [PATCH] updates to Vitesse SATA driver
Date: Thu, 30 Sep 2004 09:51:05 -0700 [thread overview]
Message-ID: <8746466a04093009511b72292b@mail.gmail.com> (raw)
In-Reply-To: <8746466a040930091743eddb@mail.gmail.com>
On Thu, 30 Sep 2004 09:17:09 -0700, Dave <dave.jiang@gmail.com> wrote:
> On Wed, 29 Sep 2004 23:28:19 -0400, Jeff Garzik <jgarzik@pobox.com > wrote:
>
> > Technically speaking, one sets the ATA_FLAG_SLAVE_POSS flag to tell the
> > libata core to scan for device 1.
> >
>
> For some odd reason we are scanning device 1 on XScale IOP platform
> with the exact same driver code. I'll have to investigate some more
> and see why it's doing that.
>
Okay, I must be not seeing something obvious. The ATA_FLAG_SLAVE_POSS
flag is not set. But I only see it being checked during reset. When
ata_bus_probe is called, it probes for ATA_MAX_DEVICES, which is both
dev 0 and dev 1. Thus dev 1 fails of course, and the core changes the
ctl without the sata driver knowing and causes interrupt mask to
remain set.....
--
-= Dave =-
Software Engineer - Advanced Development Engineering Team
Storage Component Division - Intel Corp.
mailto://dave.jiang @ intel
----
The views expressed in this email are
mine alone and do not necessarily
reflect the views of my employer
(Intel Corp.).
next prev parent reply other threads:[~2004-09-30 16:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-21 21:16 [PATCH] updates to Vitesse SATA driver Dave
2004-09-22 2:06 ` Jeremy Higdon
2004-09-22 15:59 ` Dave
2004-09-22 17:09 ` Dave
2004-09-22 20:13 ` Jeremy Higdon
2004-09-23 22:28 ` Dave
2004-09-22 20:07 ` Jeremy Higdon
2004-09-29 22:19 ` Jeff Garzik
2004-09-29 22:32 ` Dave
2004-09-30 2:34 ` Jeremy Higdon
2004-09-30 3:28 ` Jeff Garzik
2004-09-30 4:05 ` Jeremy Higdon
2004-09-30 4:25 ` [PATCH 2.6.9-rc2] per-port LED control for sata_vsc Jeremy Higdon
2004-09-30 16:17 ` [PATCH] updates to Vitesse SATA driver Dave
2004-09-30 16:51 ` Dave [this message]
2004-09-30 3:32 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8746466a04093009511b72292b@mail.gmail.com \
--to=dave.jiang@gmail.com \
--cc=jeremy@sgi.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.