From: Gerd Knorr <kraxel@bytesex.org>
To: Hanna Linder <hannal@us.ibm.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kernel-janitors@lists.osdl.org, greg@kroah.com
Subject: [Kernel-janitors] Re: [PATCH 2.6.9-rc2-mm4 zr36120.c][5/8] Convert
Date: Thu, 30 Sep 2004 08:27:48 +0000 [thread overview]
Message-ID: <20040930082748.GC20456@bytesex> (raw)
In-Reply-To: <24740000.1096500358@w-hlinder.beaverton.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 411 bytes --]
> The whole driver is CONFIG_BROKEN anyway... I only verified my changes
> didn't add new compiler errors. What part should I remove? Just this check?
pci/quirks.c does these checks and sets the flags.
Replacing with a check for "pci_pci_problems & PCIPCI_TRITON" should do.
bttv does simliar things in bttv_check_chipset() (bttv-cards.c),
you might want to have a look there ...
Gerd
--
return -ENOSIG;
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
WARNING: multiple messages have this Message-ID (diff)
From: Gerd Knorr <kraxel@bytesex.org>
To: Hanna Linder <hannal@us.ibm.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
kernel-janitors@lists.osdl.org, greg@kroah.com
Subject: Re: [PATCH 2.6.9-rc2-mm4 zr36120.c][5/8] Convert pci_find_device to pci_dev_present
Date: Thu, 30 Sep 2004 10:27:48 +0200 [thread overview]
Message-ID: <20040930082748.GC20456@bytesex> (raw)
In-Reply-To: <24740000.1096500358@w-hlinder.beaverton.ibm.com>
> The whole driver is CONFIG_BROKEN anyway... I only verified my changes
> didn't add new compiler errors. What part should I remove? Just this check?
pci/quirks.c does these checks and sets the flags.
Replacing with a check for "pci_pci_problems & PCIPCI_TRITON" should do.
bttv does simliar things in bttv_check_chipset() (bttv-cards.c),
you might want to have a look there ...
Gerd
--
return -ENOSIG;
next prev parent reply other threads:[~2004-09-30 8:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-29 22:28 [Kernel-janitors] [PATCH 2.6.9-rc2-mm4 zr36120.c][5/8] Convert Hanna Linder
2004-09-29 22:28 ` [PATCH 2.6.9-rc2-mm4 zr36120.c][5/8] Convert pci_find_device to pci_dev_present Hanna Linder
2004-09-29 22:15 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2-mm4 zr36120.c][5/8] Convert Alan Cox
2004-09-29 22:15 ` [PATCH 2.6.9-rc2-mm4 zr36120.c][5/8] Convert pci_find_device to pci_dev_present Alan Cox
2004-09-29 23:25 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2-mm4 zr36120.c][5/8] Convert Hanna Linder
2004-09-29 23:25 ` [PATCH 2.6.9-rc2-mm4 zr36120.c][5/8] Convert pci_find_device to pci_dev_present Hanna Linder
2004-09-30 8:27 ` Gerd Knorr [this message]
2004-09-30 8:27 ` Gerd Knorr
2004-09-30 22:28 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2-mm4 zr36120.c][5/8] Convert Hanna Linder
2004-09-30 22:28 ` [PATCH 2.6.9-rc2-mm4 zr36120.c][5/8] Convert pci_find_device to pci_dev_present Hanna Linder
2004-10-01 7:41 ` [Kernel-janitors] Re: [PATCH 2.6.9-rc2-mm4 zr36120.c][5/8] Convert Gerd Knorr
2004-10-01 7:41 ` [PATCH 2.6.9-rc2-mm4 zr36120.c][5/8] Convert pci_find_device to pci_dev_present Gerd Knorr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040930082748.GC20456@bytesex \
--to=kraxel@bytesex.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=greg@kroah.com \
--cc=hannal@us.ibm.com \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.