[Kernel-janitors] Could we lose the tag?

[Kernel-janitors] Could we lose the tag?

[Matthew Wilcox]

[-- Attachment #1: Type: text/plain, Size: 864 bytes --]


In my inbox, I see messages like:

24304 N   Sep 27 Nishanth Aravam ( 104) [Kernel-janitors] [PATCH 2.6.9-rc2 1/5]

All the useful information is missing, lost off the edge of the screen.
Removing the [Kernel-janitors] tag would give us 17 precious characters
back -- nearly a quarter of the width of the screen!

It wouldn't hurt if Nishanth stopped putting the kernel version in the
subject line too, but that's a secondary matter.

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [Kernel-janitors] Could we lose the tag?

[Nishanth Aravamudan]

[-- Attachment #1: Type: text/plain, Size: 593 bytes --]

On Fri, Oct 01, 2004 at 02:30:38PM +0100, Matthew Wilcox wrote:
> 
> In my inbox, I see messages like:
> 
> 24304 N   Sep 27 Nishanth Aravam ( 104) [Kernel-janitors] [PATCH 2.6.9-rc2 1/5]
> 
> All the useful information is missing, lost off the edge of the screen.
> Removing the [Kernel-janitors] tag would give us 17 precious characters
> back -- nearly a quarter of the width of the screen!
> 
> It wouldn't hurt if Nishanth stopped putting the kernel version in the
> subject line too, but that's a secondary matter.

I will remember not to do this from now on. Thanks for the tip.

-Nish

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [Kernel-janitors] Could we lose the tag?

[Ryan Anderson]

[-- Attachment #1.1: Type: text/plain, Size: 874 bytes --]

On Fri, 2004-10-01 at 09:30, Matthew Wilcox wrote:
> In my inbox, I see messages like:
> 
> 24304 N   Sep 27 Nishanth Aravam ( 104) [Kernel-janitors] [PATCH 2.6.9-rc2 1/5]
> 
> All the useful information is missing, lost off the edge of the screen.
> Removing the [Kernel-janitors] tag would give us 17 precious characters
> back -- nearly a quarter of the width of the screen!

Well the quick way to get 13 of those characters back is to change it to
[KJ] which delays the argument over whether or not it's a benefit.

> It wouldn't hurt if Nishanth stopped putting the kernel version in the
> subject line too, but that's a secondary matter.

I think that's something Andrew Morton has asked for in the "how to send
a perfect patch" document he's written.


-- 

Ryan Anderson                
AutoWeb Communications, Inc. 
email: ryan@autoweb.net 

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [Kernel-janitors] Could we lose the tag?

[Matthew Wilcox]

[-- Attachment #1: Type: text/plain, Size: 1314 bytes --]

On Fri, Oct 01, 2004 at 02:59:33PM -0400, Ryan Anderson wrote:
> On Fri, 2004-10-01 at 09:30, Matthew Wilcox wrote:
> > In my inbox, I see messages like:
> > 
> > 24304 N   Sep 27 Nishanth Aravam ( 104) [Kernel-janitors] [PATCH 2.6.9-rc2 1/5]
> > 
> > All the useful information is missing, lost off the edge of the screen.
> > Removing the [Kernel-janitors] tag would give us 17 precious characters
> > back -- nearly a quarter of the width of the screen!
> 
> > It wouldn't hurt if Nishanth stopped putting the kernel version in the
> > subject line too, but that's a secondary matter.
> 
> I think that's something Andrew Morton has asked for in the "how to send
> a perfect patch" document he's written.

Then Andrew's wrong in this matter.  Because I don't see what is being
patched, I don't review it.  This makes it at least a little bit less
perfect because I don't review it.

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [Kernel-janitors] Could we lose the tag?

[Andrew Morton]

[-- Attachment #1: Type: text/plain, Size: 1984 bytes --]

Matthew Wilcox <matthew@wil.cx> wrote:
>
> On Fri, Oct 01, 2004 at 02:59:33PM -0400, Ryan Anderson wrote:
> > On Fri, 2004-10-01 at 09:30, Matthew Wilcox wrote:
> > > In my inbox, I see messages like:
> > > 
> > > 24304 N   Sep 27 Nishanth Aravam ( 104) [Kernel-janitors] [PATCH 2.6.9-rc2 1/5]
> > > 
> > > All the useful information is missing, lost off the edge of the screen.
> > > Removing the [Kernel-janitors] tag would give us 17 precious characters
> > > back -- nearly a quarter of the width of the screen!
> > 
> > > It wouldn't hurt if Nishanth stopped putting the kernel version in the
> > > subject line too, but that's a secondary matter.
> > 
> > I think that's something Andrew Morton has asked for in the "how to send
> > a perfect patch" document he's written.
> 
> Then Andrew's wrong in this matter.  Because I don't see what is being
> patched, I don't review it.  This makes it at least a little bit less
> perfect because I don't review it.
> 

Putting the kernel version in the subject seems fairly pointless, because
all patches should be against the latest kernel version anyway.  But if
people insist I'm OK with putting the kernel version in the Subject: as
long as it is within the first [].  Because I strip out everything which is
within the first [].  I'd propose that as a convention.  So the above would
become

	[patch kernel-janitors 2.6.9-rc2 1/5] frob the knuckle

except I _do_ propagate the "janitor" info into the bk patch title, so in
this case I'd prefer

	[patch 2.6.9-rc2 1/5] janitor: frob the knuckle

which ends up in bk as

	janitor: frob the knuckle

what I am referring to in the above-referenced document is the practice of
mentioning the kernel version in the body of the changelog.  It's
information which becomes instantly obsolete so someone always has to edit
it away.  Given that people should always raise patches against the latest
kernel version and that I'm on the Cc: or To: lines, this version info is
redundant anyway.

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [Kernel-janitors] Could we lose the tag?

[Matthew Wilcox]

[-- Attachment #1: Type: text/plain, Size: 1283 bytes --]

On Fri, Oct 01, 2004 at 01:20:43PM -0700, Andrew Morton wrote:
> Matthew Wilcox <matthew@wil.cx> wrote:
> > Then Andrew's wrong in this matter.  Because I don't see what is being
> > patched, I don't review it.  This makes it at least a little bit less
> > perfect because I don't review it.
> 
> Putting the kernel version in the subject seems fairly pointless, because
> all patches should be against the latest kernel version anyway.  But if
> people insist I'm OK with putting the kernel version in the Subject: as
> long as it is within the first [].  Because I strip out everything which is
> within the first [].  I'd propose that as a convention.  So the above would
> become

Sorry Andrew, I misunderstood the reply.  We're in violent agreement --
keeping the version information is useless.  Maybe I should read your
perfect patch document ;-)

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [Kernel-janitors] Could we lose the tag?

[Randy.Dunlap]

[-- Attachment #1: Type: text/plain, Size: 797 bytes --]

On Fri, 01 Oct 2004 14:59:33 -0400 Ryan Anderson wrote:

| On Fri, 2004-10-01 at 09:30, Matthew Wilcox wrote:
| > In my inbox, I see messages like:
| > 
| > 24304 N   Sep 27 Nishanth Aravam ( 104) [Kernel-janitors] [PATCH 2.6.9-rc2 1/5]
| > 
| > All the useful information is missing, lost off the edge of the screen.
| > Removing the [Kernel-janitors] tag would give us 17 precious characters
| > back -- nearly a quarter of the width of the screen!
| 
| Well the quick way to get 13 of those characters back is to change it to
| [KJ] which delays the argument over whether or not it's a benefit.

If I don't see any violent objections, I'll change it to
[KJ] sometime this week.

-- 
~Randy
MOTD:  Always include version info.
(Again.  Sometimes I think ln -s /usr/src/linux/.config .signature)

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors