From: Pavel Machek <pavel@ucw.cz>
To: Andrew Morton <akpm@zip.com.au>,
kernel list <linux-kernel@vger.kernel.org>,
Rusty trivial patch monkey Russell <trivial@rustcorp.com.au>,
aeb@cwi.nl
Subject: sddr09: don't hide real errors in debug prints
Date: Mon, 4 Oct 2004 18:13:51 +0200 [thread overview]
Message-ID: <20041004161351.GA4757@elf.ucw.cz> (raw)
Hi!
sddr09 hides in debug prints. That seems wrong and this fixes
it. Please apply,
Pavel
--- tmp/linux/drivers/usb/storage/sddr09.c 2004-10-01 00:30:20.000000000 +0200
+++ linux/drivers/usb/storage/sddr09.c 2004-10-01 00:47:53.000000000 +0200
@@ -370,7 +371,7 @@
result = sddr09_send_scsi_command(us, command, 12);
if (result != USB_STOR_TRANSPORT_GOOD) {
- US_DEBUGP("Result for send_control in sddr09_read2%d %d\n",
+ printk(KERN_WARNING "Error in send_control in sddr09_read2%d %d\n",
x, result);
return result;
}
@@ -379,7 +380,7 @@
buf, bulklen, use_sg, NULL);
if (result != USB_STOR_XFER_GOOD) {
- US_DEBUGP("Result for bulk_transfer in sddr09_read2%d %d\n",
+ printk(KERN_WARNING "Error in bulk_transfer in sddr09_read2%d %d\n",
x, result);
return USB_STOR_TRANSPORT_ERROR;
}
@@ -498,7 +499,7 @@
result = sddr09_send_scsi_command(us, command, 12);
if (result != USB_STOR_TRANSPORT_GOOD)
- US_DEBUGP("Result for send_control in sddr09_erase %d\n",
+ printk(KERN_WARNING "Error in send_control in sddr09_erase %d\n",
result);
return result;
@@ -556,7 +557,7 @@
result = sddr09_send_scsi_command(us, command, 12);
if (result != USB_STOR_TRANSPORT_GOOD) {
- US_DEBUGP("Result for send_control in sddr09_writeX %d\n",
+ printk(KERN_WARNING "Error in send_control in sddr09_writeX %d\n",
result);
return result;
}
@@ -565,7 +566,7 @@
buf, bulklen, use_sg, NULL);
if (result != USB_STOR_XFER_GOOD) {
- US_DEBUGP("Result for bulk_transfer in sddr09_writeX %d\n",
+ printk(KERN_WARNING "Error in bulk_transfer in sddr09_writeX %d\n",
result);
return USB_STOR_TRANSPORT_ERROR;
}
@@ -634,7 +635,7 @@
result = sddr09_send_scsi_command(us, command, 4*nsg+3);
if (result != USB_STOR_TRANSPORT_GOOD) {
- US_DEBUGP("Result for send_control in sddr09_read_sg %d\n",
+ printk(KERN_WARNING "Error in send_control in sddr09_read_sg %d\n",
result);
return result;
}
@@ -647,7 +648,7 @@
buf, bulklen, NULL);
kfree(buf);
if (result != USB_STOR_XFER_GOOD) {
- US_DEBUGP("Result for bulk_transfer in sddr09_read_sg %d\n",
+ printk(KERN_WARNING "Error in bulk_transfer in sddr09_read_sg %d\n",
result);
return USB_STOR_TRANSPORT_ERROR;
}
@@ -710,7 +711,7 @@
len = min(sectors, (unsigned int) info->blocksize) * info->pagesize;
buffer = kmalloc(len, GFP_NOIO);
if (buffer == NULL) {
- printk("sddr09_read_data: Out of memory\n");
+ printk(KERN_ERR "sddr09_read_data: Out of memory\n");
return USB_STOR_TRANSPORT_ERROR;
}
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
next reply other threads:[~2004-10-04 16:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-04 16:13 Pavel Machek [this message]
2004-10-04 19:14 ` sddr09: don't hide real errors in debug prints Andries Brouwer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041004161351.GA4757@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=aeb@cwi.nl \
--cc=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.