From: Andries Brouwer <Andries.Brouwer@cwi.nl>
To: Pavel Machek <pavel@ucw.cz>
Cc: Andrew Morton <akpm@zip.com.au>,
kernel list <linux-kernel@vger.kernel.org>,
Rusty trivial patch monkey Russell <trivial@rustcorp.com.au>,
Andries.Brouwer@cwi.nl
Subject: Re: sddr09: don't hide real errors in debug prints
Date: Mon, 4 Oct 2004 21:14:10 +0200 [thread overview]
Message-ID: <20041004191410.GA22683@apps.cwi.nl> (raw)
In-Reply-To: <20041004161351.GA4757@elf.ucw.cz>
On Mon, Oct 04, 2004 at 06:13:51PM +0200, Pavel Machek wrote:
> sddr09 hides in debug prints. That seems wrong and this fixes
> it. Please apply,
> Pavel
>
> --- tmp/linux/drivers/usb/storage/sddr09.c 2004-10-01 00:30:20.000000000 +0200
> +++ linux/drivers/usb/storage/sddr09.c 2004-10-01 00:47:53.000000000 +0200
> @@ -370,7 +371,7 @@
> result = sddr09_send_scsi_command(us, command, 12);
>
> if (result != USB_STOR_TRANSPORT_GOOD) {
> - US_DEBUGP("Result for send_control in sddr09_read2%d %d\n",
> + printk(KERN_WARNING "Error in send_control in sddr09_read2%d %d\n",
> x, result);
> return result;
> }
Hmm. I have no serious objections -- this is just a little kernel bloat,
but on the other hand, I don't see the point. Why do you want a printk
when some intermediate routine passes an error from a lower level
to a higher level?
When debugging that may be useful. But otherwise?
Andries
prev parent reply other threads:[~2004-10-04 19:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-04 16:13 sddr09: don't hide real errors in debug prints Pavel Machek
2004-10-04 19:14 ` Andries Brouwer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041004191410.GA22683@apps.cwi.nl \
--to=andries.brouwer@cwi.nl \
--cc=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=trivial@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.