bug in 2.6.8.1 scsi_block.c for CDROM "get configuration" ioctl

bug in 2.6.8.1 scsi_block.c for CDROM "get configuration" ioctl

[Luke Kenneth Casson Leighton]

the following patch needs to be added in order for k3b to operate
correctly as a non-root user (there's a linux capability check in
scsi_ioctl.c's verify_command() function)

apparently this is fixed for 2.6.9-rcsomething.

l.


Index: drivers/block/scsi_ioctl.c
===================================================================
RCS file: /cvsroot/selinux/nsa/linux-2.6/drivers/block/scsi_ioctl.c,v
retrieving revision 1.1.1.9
diff -u -r1.1.1.9 scsi_ioctl.c
--- drivers/block/scsi_ioctl.c	19 Aug 2004 14:25:16 -0000	1.1.1.9
+++ drivers/block/scsi_ioctl.c	4 Oct 2004 14:07:25 -0000
@@ -146,6 +146,7 @@
 		safe_for_read(GPCMD_READ_TOC_PMA_ATIP),
 		safe_for_read(GPCMD_REPORT_KEY),
 		safe_for_read(GPCMD_SCAN),
+		safe_for_read(GPCMD_GET_CONFIGURATION),
 
 		/* Basic writing commands */
 		safe_for_write(WRITE_6),
-- 
--
Truth, honesty and respect are rare commodities that all spring from
the same well: Love.  If you love yourself and everyone and everything
around you, funnily and coincidentally enough, life gets a lot better.
--
<a href="http://lkcl.net">      lkcl.net      </a> <br />
<a href="mailto:lkcl@lkcl.net"> lkcl@lkcl.net </a> <br />


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

Re: bug in 2.6.8.1 scsi_block.c for CDROM "get configuration" ioctl

[Luke Kenneth Casson Leighton]

uh, actually there's a few more than just this one.

debian's latest 2.6.8-1 kernel patches has this fixed properly.
there are two reasons why i mention it here:

1) selinux has its own kernel tree, which was last updated to 2.6.8.1

2) anyone else who uses an unpatched latest cvs tree from sf.net may run
into difficulties [missing expected features] like i have.

l.

On Mon, Oct 04, 2004 at 03:27:12PM +0100, Luke Kenneth Casson Leighton wrote:
> the following patch needs to be added in order for k3b to operate
> correctly as a non-root user (there's a linux capability check in
> scsi_ioctl.c's verify_command() function)
> 
> apparently this is fixed for 2.6.9-rcsomething.

> +		safe_for_read(GPCMD_GET_CONFIGURATION),

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.