[Kernel-janitors] [PATCH 2.6] pci-hplj.c: replace pci_find_device

[Kernel-janitors] [PATCH 2.6] pci-hplj.c: replace pci_find_device

[Hanna Linder]

[-- Attachment #1: Type: text/plain, Size: 883 bytes --]



As pci_find_device is going away I have replaced this call with pci_get_device.
If  someone has access to an RM200 or RM300 and could test this I would appreciate it.

Thanks.

Hanna Linder
IBM Linux Technology Center

Signed-off-by: Hanna Linder <hannal@us.ibm.com>
---

diff -Nrup linux-2.6.9-rc3-mm2cln/arch/mips/pci/pci-hplj.c linux-2.6.9-rc3-mm2patch/arch/mips/pci/pci-hplj.c
--- linux-2.6.9-rc3-mm2cln/arch/mips/pci/pci-hplj.c	2004-09-29 20:05:21.000000000 -0700
+++ linux-2.6.9-rc3-mm2patch/arch/mips/pci/pci-hplj.c	2004-10-04 14:20:25.307153544 -0700
@@ -118,7 +118,7 @@ void __init pcibios_fixup_irqs(void)
 	struct pci_dev *dev = NULL;
 	int slot_num;
 
-	while ((dev = pci_find_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL) {
+	while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL) {
 		slot_num = PCI_SLOT(dev->devfn);
 		switch (slot_num) {
 		case 2:



[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

[PATCH 2.6] pci-hplj.c: replace pci_find_device with pci_get_device

[Hanna Linder]

As pci_find_device is going away I have replaced this call with pci_get_device.
If  someone has access to an RM200 or RM300 and could test this I would appreciate it.

Thanks.

Hanna Linder
IBM Linux Technology Center

Signed-off-by: Hanna Linder <hannal@us.ibm.com>
---

diff -Nrup linux-2.6.9-rc3-mm2cln/arch/mips/pci/pci-hplj.c linux-2.6.9-rc3-mm2patch/arch/mips/pci/pci-hplj.c
--- linux-2.6.9-rc3-mm2cln/arch/mips/pci/pci-hplj.c	2004-09-29 20:05:21.000000000 -0700
+++ linux-2.6.9-rc3-mm2patch/arch/mips/pci/pci-hplj.c	2004-10-04 14:20:25.307153544 -0700
@@ -118,7 +118,7 @@ void __init pcibios_fixup_irqs(void)
 	struct pci_dev *dev = NULL;
 	int slot_num;
 
-	while ((dev = pci_find_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL) {
+	while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL) {
 		slot_num = PCI_SLOT(dev->devfn);
 		switch (slot_num) {
 		case 2:

[Kernel-janitors] Re: [PATCH 2.6] pci-hplj.c: replace

[Ralf Baechle]

[-- Attachment #1: Type: text/plain, Size: 515 bytes --]

On Mon, Oct 04, 2004 at 02:26:47PM -0700, Hanna Linder wrote:

> As pci_find_device is going away I have replaced this call with pci_get_device.

Looks good ...

> If  someone has access to an RM200 or RM300 and could test this I would appreciate it.

Except that piece of code isn't for an RM[23]00 but a HP Laserjet (yes,
that paper eating thing ;-) and hasn't seen any update or feedback from
the original submitters since the original submission, so the entire HPLJ
code is a candidate for removal ...

   Ralf

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [PATCH 2.6] pci-hplj.c: replace pci_find_device with pci_get_device

[Ralf Baechle]

On Mon, Oct 04, 2004 at 02:26:47PM -0700, Hanna Linder wrote:

> As pci_find_device is going away I have replaced this call with pci_get_device.

Looks good ...

> If  someone has access to an RM200 or RM300 and could test this I would appreciate it.

Except that piece of code isn't for an RM[23]00 but a HP Laserjet (yes,
that paper eating thing ;-) and hasn't seen any update or feedback from
the original submitters since the original submission, so the entire HPLJ
code is a candidate for removal ...

   Ralf

[Kernel-janitors] Re: [PATCH 2.6] pci-hplj.c: replace

[Hanna Linder]

[-- Attachment #1: Type: text/plain, Size: 872 bytes --]

--On Monday, October 04, 2004 11:41:07 PM +0200 Ralf Baechle <ralf@linux-mips.org> wrote:

> On Mon, Oct 04, 2004 at 02:26:47PM -0700, Hanna Linder wrote:
>> If  someone has access to an RM200 or RM300 and could test this I would appreciate it.
> 
> Except that piece of code isn't for an RM[23]00 but a HP Laserjet (yes,
> that paper eating thing ;-) and hasn't seen any update or feedback from
> the original submitters since the original submission, so the entire HPLJ
> code is a candidate for removal ...
> 
>    Ralf

Ahh thanks, the comments at the top of the file confused me:

 * SNI specific PCI support for RM200/RM300.

I have no opinion on the codes deletion or not. I'm simply changing all
occurances of pci_find_device. Hopefully people will not confuse that
work with my having any familiarity with the actual devices themselves :)

Thanks a lot.

Hanna



[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [PATCH 2.6] pci-hplj.c: replace pci_find_device with pci_get_device

[Hanna Linder]

--On Monday, October 04, 2004 11:41:07 PM +0200 Ralf Baechle <ralf@linux-mips.org> wrote:

> On Mon, Oct 04, 2004 at 02:26:47PM -0700, Hanna Linder wrote:
>> If  someone has access to an RM200 or RM300 and could test this I would appreciate it.
> 
> Except that piece of code isn't for an RM[23]00 but a HP Laserjet (yes,
> that paper eating thing ;-) and hasn't seen any update or feedback from
> the original submitters since the original submission, so the entire HPLJ
> code is a candidate for removal ...
> 
>    Ralf

Ahh thanks, the comments at the top of the file confused me:

 * SNI specific PCI support for RM200/RM300.

I have no opinion on the codes deletion or not. I'm simply changing all
occurances of pci_find_device. Hopefully people will not confuse that
work with my having any familiarity with the actual devices themselves :)

Thanks a lot.

Hanna

[Kernel-janitors] Re: [PATCH 2.6] pci-hplj.c: replace

[David Woodhouse]

[-- Attachment #1: Type: text/plain, Size: 408 bytes --]

On Mon, 2004-10-04 at 23:41 +0200, Ralf Baechle wrote:
> Except that piece of code isn't for an RM[23]00 but a HP Laserjet (yes,
> that paper eating thing ;-) and hasn't seen any update or feedback from
> the original submitters since the original submission, so the entire HPLJ
> code is a candidate for removal ...

Any idea precisely what model, and how to get it installed? 
eBay calls... :)

-- 
dwmw2


[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [PATCH 2.6] pci-hplj.c: replace pci_find_device with pci_get_device

[David Woodhouse]

On Mon, 2004-10-04 at 23:41 +0200, Ralf Baechle wrote:
> Except that piece of code isn't for an RM[23]00 but a HP Laserjet (yes,
> that paper eating thing ;-) and hasn't seen any update or feedback from
> the original submitters since the original submission, so the entire HPLJ
> code is a candidate for removal ...

Any idea precisely what model, and how to get it installed? 
eBay calls... :)

-- 
dwmw2

[Kernel-janitors] Re: [PATCH 2.6] pci-hplj.c: replace

[Ralf Baechle]

[-- Attachment #1: Type: text/plain, Size: 913 bytes --]

On Tue, Oct 05, 2004 at 02:03:16PM +0100, David Woodhouse wrote:

> On Mon, 2004-10-04 at 23:41 +0200, Ralf Baechle wrote:
> > Except that piece of code isn't for an RM[23]00 but a HP Laserjet (yes,
> > that paper eating thing ;-) and hasn't seen any update or feedback from
> > the original submitters since the original submission, so the entire HPLJ
> > code is a candidate for removal ...
> 
> Any idea precisely what model, and how to get it installed? 
> eBay calls... :)

They only ever published the initial code drop.  No code maintenance since
or any kind of documentation ...  However one of the group of code submitters
back then was claiming to run Gnome with remote X display - probably because
at least back then there was no support for the printing hw and anyway,
the refresh rate of a printer is somewhat limited ;-)

As I recall the code was originally submitted by roger_twede@hp.com.

  Ralf

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [PATCH 2.6] pci-hplj.c: replace pci_find_device with pci_get_device

[Ralf Baechle]

On Tue, Oct 05, 2004 at 02:03:16PM +0100, David Woodhouse wrote:

> On Mon, 2004-10-04 at 23:41 +0200, Ralf Baechle wrote:
> > Except that piece of code isn't for an RM[23]00 but a HP Laserjet (yes,
> > that paper eating thing ;-) and hasn't seen any update or feedback from
> > the original submitters since the original submission, so the entire HPLJ
> > code is a candidate for removal ...
> 
> Any idea precisely what model, and how to get it installed? 
> eBay calls... :)

They only ever published the initial code drop.  No code maintenance since
or any kind of documentation ...  However one of the group of code submitters
back then was claiming to run Gnome with remote X display - probably because
at least back then there was no support for the printing hw and anyway,
the refresh rate of a printer is somewhat limited ;-)

As I recall the code was originally submitted by roger_twede@hp.com.

  Ralf