Re: [PATCH] Realtime LSM

[Chris Wright <chrisw@osdl.org>]

* Jack O'Quin (joq@io.com) wrote:
> Chris Wright <chrisw@osdl.org> writes:
> > use in_group_p
> 
> I looked at that, it wasn't clear to me whether to use in_group_p() or
> in_egroup_p().  How do you choose?

For most cases they'll be identical.  The difference is whether you're
comparing the fsgid or the egid.  The former is what's used for file
access, the latter might make more sense in your case.  However, in
99.9% of the cases you care about fsgid == egid, so it's a wash.  So,
in_egroup_p matches a bit better.  Relative to the other patches...

thanks,
-chris
-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net


--- security/realtime.c~rm_CONFIG_SECURITY	2004-10-08 16:16:35.000000000 -0700
+++ security/realtime.c	2004-10-08 21:06:28.020084984 -0700
@@ -66,7 +66,7 @@
 	if ((gid == e_gid) || (gid == current->gid))
 		return 1;
 
-	return in_group_p(gid);
+	return in_egroup_p(gid);
 }
 
 static int realtime_bprm_set_security(struct linux_binprm *bprm)