All of lore.kernel.org
 help / color / mirror / Atom feed
* [Ocfs2-devel] Re: [Ocfs2-commits] bryce commits r1573 - in trunk: . mount.ocfs
       [not found] <200410141425.i9EEPDZS029376@oss.oracle.com>
@ 2004-10-14 13:50 ` Christoph Hellwig
  2004-10-15 22:44   ` Joel Becker
  0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2004-10-14 13:50 UTC (permalink / raw)
  To: ocfs2-devel

> +int module_loaded(char * module) {
> +	int fd;
> +	int i;
> +	char line[100];
> +
> +	if ((fd = open("/proc/modules", O_RDONLY)) >= 0 ) {
> +                        while ((i = read(fd, line, 100)) > 0) {
> +                                if (strstr(line, module) != 0) {
> +					close(fd);
> +					return (1);
> +				}
> +                        close(fd);
> +                        return (0);
> +                }
> +	}
> +}

this check is bogus, the kernel will autload a filesystem on the first
mount attempt.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [Ocfs2-devel] Re: [Ocfs2-commits] bryce commits r1573 - in trunk: . mount.ocfs
  2004-10-14 13:50 ` [Ocfs2-devel] Re: [Ocfs2-commits] bryce commits r1573 - in trunk: . mount.ocfs Christoph Hellwig
@ 2004-10-15 22:44   ` Joel Becker
  0 siblings, 0 replies; 2+ messages in thread
From: Joel Becker @ 2004-10-15 22:44 UTC (permalink / raw)
  To: ocfs2-devel

On Thu, Oct 14, 2004 at 08:50:29PM +0200, Christoph Hellwig wrote:
> > +int module_loaded(char * module) {
> this check is bogus, the kernel will autload a filesystem on the first
> mount attempt.

	Not if the module fails to load without magic module parameters,
as OCFS2 still does.

Joel

-- 

"Can any of you seriously say the Bill of Rights could get through
 Congress today?  It wouldn't even get out of committee."
	- F. Lee Bailey

Joel Becker
Senior Member of Technical Staff
Oracle Corporation
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-10-15 22:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <200410141425.i9EEPDZS029376@oss.oracle.com>
2004-10-14 13:50 ` [Ocfs2-devel] Re: [Ocfs2-commits] bryce commits r1573 - in trunk: . mount.ocfs Christoph Hellwig
2004-10-15 22:44   ` Joel Becker

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.