From: Matthew Wilcox <matthew@wil.cx>
To: David Howells <dhowells@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [RESEND][PATCH 4/6] Add page becoming writable notification
Date: Thu, 14 Oct 2004 20:29:26 +0100 [thread overview]
Message-ID: <20041014192926.GT16153@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <24449.1097780701@redhat.com>
On Thu, Oct 14, 2004 at 08:05:01PM +0100, David Howells wrote:
> +static inline int do_wp_page_mk_pte_writable(struct mm_struct *mm,
> + struct vm_area_struct *vma,
> + unsigned long address,
> + pte_t *page_table,
> + struct page *old_page,
> + pte_t pte)
I protest. There are at least 3 vowels and 2 non-acronyms in this
function name. Also, 6 arguments is clearly too few. Can we not also
pass a struct urb, an ethtool_wolinfo and a Scsi_Cmnd?
--
"Next the statesmen will invent cheap lies, putting the blame upon
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince
himself that the war is just, and will thank God for the better sleep
he enjoys after this process of grotesque self-deception." -- Mark Twain
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <matthew@wil.cx>
To: David Howells <dhowells@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [RESEND][PATCH 4/6] Add page becoming writable notification
Date: Thu, 14 Oct 2004 20:29:26 +0100 [thread overview]
Message-ID: <20041014192926.GT16153@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <24449.1097780701@redhat.com>
On Thu, Oct 14, 2004 at 08:05:01PM +0100, David Howells wrote:
> +static inline int do_wp_page_mk_pte_writable(struct mm_struct *mm,
> + struct vm_area_struct *vma,
> + unsigned long address,
> + pte_t *page_table,
> + struct page *old_page,
> + pte_t pte)
I protest. There are at least 3 vowels and 2 non-acronyms in this
function name. Also, 6 arguments is clearly too few. Can we not also
pass a struct urb, an ethtool_wolinfo and a Scsi_Cmnd?
--
"Next the statesmen will invent cheap lies, putting the blame upon
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince
himself that the war is just, and will thank God for the better sleep
he enjoys after this process of grotesque self-deception." -- Mark Twain
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2004-10-14 19:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-14 19:05 [RESEND][PATCH 4/6] Add page becoming writable notification David Howells
2004-10-14 19:05 ` David Howells
2004-10-14 19:29 ` Matthew Wilcox [this message]
2004-10-14 19:29 ` Matthew Wilcox
2004-10-14 20:35 ` Christoph Hellwig
2004-10-14 20:35 ` Christoph Hellwig
2004-10-15 15:05 ` David Howells
2004-10-15 15:05 ` David Howells
2004-10-15 15:34 ` Christoph Hellwig
2004-10-15 15:34 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041014192926.GT16153@parcelfarce.linux.theplanet.co.uk \
--to=matthew@wil.cx \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.