[KJ] new janitor info

[KJ] new janitor info

[Daniele Pizzoni]

[-- Attachment #1: Type: text/plain, Size: 1585 bytes --]

Hello!

I'd like to start doing some work as janitor, I'm not exactly an
absolute kernel newbie (some simple driver hacking experience), but I'd
like to start with simple things just to start getting involved.

I had a look at the TODO list on janitor.kernelnewbies.org. I think I
could to start with something from the following list:

----8<--------8<--------8<--------8<--------8<--------8<----

From: Andrey Panin <pazke at orbita dot don dot sitek dot net>

- check printk() calls (should include appropriate KERN_* constant).

------------------------------------------------------------------------
From Domen Puncer:
- pr_debug() from kernel.h could replace a lot of DPRINTK and similar macros.
- same for pr_info()

------------------------------------------------------------------------
From Domen Puncer:
- min/max macros from kernel.h are safe, a lot of handcrafted MIN/MAX are not.

------------------------------------------------------------------------
From Domen Puncer:
- remove string concatenation with __FUNCTION__ (get rid of
warnings, and get ready for __func__):
-printk(KERN_INFO "blabla " __FUNCTION__ "\n");
+printk(KERN_INFO "blabla %s\n", __FUNCTION__);

However, do not convert _FUNCTION_ to _func_ because older
gcc versions do not support _func_.

----8<--------8<--------8<--------8<--------8<--------8<----


Anyway I'd like to know if the someone is already working on the same
topics.

Also, are patches to be sent to the kernel-janitors list only?

Thanks for you help, beware of the many questions I'm going to ask you!
:)

Bye
Daniele Pizzoni



[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] new janitor info

[Gustavo Franco]

[-- Attachment #1: Type: text/plain, Size: 556 bytes --]

On Fri, 2004-10-15 at 00:38 +0200, Daniele Pizzoni wrote:
> Hello!

Hi Danielle.

> [...]
> Anyway I'd like to know if the someone is already working on the same
> topics.

I can't tell you atm.

> Also, are patches to be sent to the kernel-janitors list only?

Yes, i suggest you to check the list archives[0] to see how the patches
are handled. The "CodingStyle" and "SubmittingPatches"[1] too.

[0] = http://lists.osdl.org/pipermail/kernel-janitors/
[1] = kernel source 'documentation/' directory.

Hope that helps,
Gustavo Franco -- <stratus@acm.org>


[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] new janitor info

[maximilian attems]

[-- Attachment #1: Type: text/plain, Size: 2346 bytes --]

On Fri, 15 Oct 2004, Daniele Pizzoni wrote:

> Hello!
> 
> I'd like to start doing some work as janitor, I'm not exactly an
> absolute kernel newbie (some simple driver hacking experience), but I'd
> like to start with simple things just to start getting involved.
> 
> I had a look at the TODO list on janitor.kernelnewbies.org. I think I
> could to start with something from the following list:
> 
> ----8<--------8<--------8<--------8<--------8<--------8<----
> 
> From: Andrey Panin <pazke at orbita dot don dot sitek dot net>
> 
> - check printk() calls (should include appropriate KERN_* constant).

is always appreciated.
 
> ------------------------------------------------------------------------
> >From Domen Puncer:
> - pr_debug() from kernel.h could replace a lot of DPRINTK and similar macros.
> - same for pr_info()

lots of open cases.
 
> ------------------------------------------------------------------------
> >From Domen Puncer:
> - min/max macros from kernel.h are safe, a lot of handcrafted MIN/MAX are not.

some work done, you might want to coordinate with
Michael Veeck <michael.veeck@gmx.net> first taker
and also Clemens Buchacher <drizzd@aon.at>
 
> ------------------------------------------------------------------------
> >From Domen Puncer:
> - remove string concatenation with __FUNCTION__ (get rid of
> warnings, and get ready for __func__):
> -printk(KERN_INFO "blabla " __FUNCTION__ "\n");
> +printk(KERN_INFO "blabla %s\n", __FUNCTION__);
> 
> However, do not convert _FUNCTION_ to _func_ because older
> gcc versions do not support _func_.

these is mostly done, you let get a drink for finding one,
with latest kjt patchset applied.
anyway i'm kidding.
 
> ----8<--------8<--------8<--------8<--------8<--------8<----
> 
> 
> Anyway I'd like to know if the someone is already working on the same
> topics.
> 
> Also, are patches to be sent to the kernel-janitors list only?

that's up to you, if you'll find an MAINTAINER entry to the driver
you are free to cc him.

the kjt patchset pick all the good patches that were send to the
mailinglist and that are not yet merged by linus to push them
upstream.
 
> Thanks for you help, beware of the many questions I'm going to ask you!
> :)

hope that helps, and happy to read your patches soon. ;-)

--
maks
kernel janitor  	http://janitor.kernelnewbies.org/


[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors