All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Aravamudan <nacc@us.ibm.com>
To: Daniele Pizzoni <auouo@tin.it>
Cc: lkml <linux-kernel@vger.kernel.org>,
	kernel-janitors <kernel-janitors@lists.osdl.org>,
	pazke@orbita.don.sitek.net
Subject: Re: [KJ] janitoring printk with no KERN_ constants, kill all defaults?
Date: Fri, 15 Oct 2004 16:17:55 +0000	[thread overview]
Message-ID: <20041015161755.GB2134@us.ibm.com> (raw)
In-Reply-To: <1097855099.3004.64.camel@pdp11.tsho.org>

[-- Attachment #1: Type: text/plain, Size: 637 bytes --]

On Fri, Oct 15, 2004 at 05:44:59PM +0200, Daniele Pizzoni wrote:
> I'm investigating this (from the kernel janitors TODO list):

<snip>

> I ask, what rationale there is behind checking all printks to include
> the "appropriate" constant? Should then we make printk fail when called
> without KERN_ constant? Or can I force with a sed script all defaulted
> printk to KERN_WARNING?

I think the rationale is to compare the comments from linux/kernel.h for
the KERN_* definitions to their usage in the code and make sure they
correspond accordingly, e.g. KERN_EMERG is only used if the system is
actually unusable.

Hope that helps,
Nish

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Aravamudan <nacc@us.ibm.com>
To: Daniele Pizzoni <auouo@tin.it>
Cc: lkml <linux-kernel@vger.kernel.org>,
	kernel-janitors <kernel-janitors@lists.osdl.org>,
	pazke@orbita.don.sitek.net
Subject: Re: [KJ] janitoring printk with no KERN_ constants, kill all defaults?
Date: Fri, 15 Oct 2004 09:17:55 -0700	[thread overview]
Message-ID: <20041015161755.GB2134@us.ibm.com> (raw)
In-Reply-To: <1097855099.3004.64.camel@pdp11.tsho.org>

On Fri, Oct 15, 2004 at 05:44:59PM +0200, Daniele Pizzoni wrote:
> I'm investigating this (from the kernel janitors TODO list):

<snip>

> I ask, what rationale there is behind checking all printks to include
> the "appropriate" constant? Should then we make printk fail when called
> without KERN_ constant? Or can I force with a sed script all defaulted
> printk to KERN_WARNING?

I think the rationale is to compare the comments from linux/kernel.h for
the KERN_* definitions to their usage in the code and make sure they
correspond accordingly, e.g. KERN_EMERG is only used if the system is
actually unusable.

Hope that helps,
Nish

  parent reply	other threads:[~2004-10-15 16:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-15 14:48 [KJ] janitoring printk with no KERN_ constants, kill all defaults? Daniele Pizzoni
2004-10-15 15:44 ` Daniele Pizzoni
2004-10-15 15:46 ` [KJ] Re: janitoring printk with no KERN_ constants, Dave Jones
2004-10-15 15:46   ` janitoring printk with no KERN_ constants, kill all defaults? Dave Jones
2004-10-15 17:20   ` Daniele Pizzoni
2004-10-15 16:17 ` Nishanth Aravamudan [this message]
2004-10-15 16:17   ` [KJ] " Nishanth Aravamudan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041015161755.GB2134@us.ibm.com \
    --to=nacc@us.ibm.com \
    --cc=auouo@tin.it \
    --cc=kernel-janitors@lists.osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pazke@orbita.don.sitek.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.