Disk full and writting to pre-allocated area on ReiserFS

Disk full and writting to pre-allocated area on ReiserFS

[Peter Zaitsev]

Hi,

I'm running SuSE 9.1  Kernel 2.6.5-7.108-default 
But I would guess it applies to large variety of platforms as we have
customers reporting the same problem.

I'm using reiserfs:
/dev/md0 on /data type reiserfs (rw,noatime,notail,data=writeback)

The problem is in case of disk full condition,  "Disk full" error is
being reported even if write happens to Pre-Allocated area, in my case
to Innodb recovery log files.

This is very unfortunate as in such case Innodb has no way but to
terminate database server.  These logs are specially pre-allocated so 
one would not run in such condition.

Question: Is there any way to avoid this problem with Reiserfs ? 


-- 
Peter Zaitsev, Senior Support Engineer
MySQL AB, www.mysql.com

Re: Disk full and writting to pre-allocated area on ReiserFS

[Hans Reiser]

Peter Zaitsev wrote:

>Hi,
>
>I'm running SuSE 9.1  Kernel 2.6.5-7.108-default 
>But I would guess it applies to large variety of platforms as we have
>customers reporting the same problem.
>
>I'm using reiserfs:
>/dev/md0 on /data type reiserfs (rw,noatime,notail,data=writeback)
>
>The problem is in case of disk full condition,  "Disk full" error is
>being reported even if write happens to Pre-Allocated area, in my case
>to Innodb recovery log files.
>
>This is very unfortunate as in such case Innodb has no way but to
>terminate database server.  These logs are specially pre-allocated so 
>one would not run in such condition.
>
>Question: Is there any way to avoid this problem with Reiserfs ? 
>
>
>  
>
vs or chris or jeff, can you comment?

Re: Disk full and writting to pre-allocated area on ReiserFS

[Vladimir Saveliev]

[-- Attachment #1: Type: text/plain, Size: 1167 bytes --]

Hello

Could someone please forward this mail to peter@mysql.com (for unknown
reasons I can not send anything to some addresses).


On Sat, 2004-10-16 at 19:22, Hans Reiser wrote:
> Peter Zaitsev wrote:
> 
> >Hi,
> >
> >I'm running SuSE 9.1  Kernel 2.6.5-7.108-default 
> >But I would guess it applies to large variety of platforms as we have
> >customers reporting the same problem.
> >
> >I'm using reiserfs:
> >/dev/md0 on /data type reiserfs (rw,noatime,notail,data=writeback)
> >
> >The problem is in case of disk full condition,  "Disk full" error is
> >being reported even if write happens to Pre-Allocated area, in my case
> >to Innodb recovery log files.
> >
> >This is very unfortunate as in such case Innodb has no way but to
> >terminate database server.  These logs are specially pre-allocated so 
> >one would not run in such condition.
> >
> >Question: Is there any way to avoid this problem with Reiserfs ? 
> >

Would you please check whether attached patch fixes the problem?


> >
> >  
> >
> vs or chris or jeff, can you comment?
> 

This looks like a bug in reiserfs_file_write. It does not distinguish
whether new disk space is to be allocate.


[-- Attachment #2: file.c.diff2 --]
[-- Type: text/plain, Size: 270 bytes --]

--- file.c~	2004-10-02 12:29:33.223660850 +0400
+++ file.c	2004-10-08 10:03:03.001561661 +0400
@@ -1137,6 +1137,8 @@
 	return result;
     }
 
+    return generic_file_write(file, buf, count, ppos);
+
     if ( unlikely((ssize_t) count < 0 ))
         return -EINVAL;
 

Re: Disk full and writting to pre-allocated area on ReiserFS

[mjt]

On Mon, Oct 18, 2004 at 02:45:10PM +0400, Vladimir Saveliev wrote:
>Could someone please forward this mail to peter@mysql.com (for unknown
>reasons I can not send anything to some addresses).

Forwarded.

-- 
mjt