From: Ingo Molnar <mingo@elte.hu>
To: Paul Mackerras <paulus@samba.org>
Cc: akpm@osdl.org, torvalds@osdl.org, anton@samba.org,
benh@kernel.crashing.org, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] Fix PREEMPT_ACTIVE definition
Date: Wed, 20 Oct 2004 10:33:58 +0200 [thread overview]
Message-ID: <20041020083358.GB23396@elte.hu> (raw)
In-Reply-To: <16758.3807.954319.110353@cargo.ozlabs.ibm.com>
* Paul Mackerras <paulus@samba.org> wrote:
> When the generic IRQ stuff went in, it seems that HARDIRQ_BITS got
> bumped from 9 (for ppc64) up to 12. Consequently, the PREEMPT_ACTIVE
> bit is now within HARDIRQ_MASK, and I get in_interrupt() falsely
> returning true when PREEMPT_ACTIVE is set, and thus a BUG_ON tripping
> in arch/ppc64/mm/tlb.c.
indeed! The reason why this problem didnt trigger on the other
architectures is that the in_atomic() test is separate and excludes
PREEMPT_ACTIVE.
> The patch below fixes this by changing PREEMPT_ACTIVE to 0x10000000. I
> have changed the PREEMPT_ACTIVE definitions for each of the
> architectures that define CONFIG_GENERIC_HARDIRQS (i386, ppc, ppc64,
> x86_64) and fixed the comment in include/linux/hardirq.h. We could
> perhaps move the PREEMPT_ACTIVE definition to include/linux/hardirq.h
> - I don't know why it is still per-arch.
>
> Signed-off-by: Paul Mackerras <paulus@samba.org>
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo
next prev parent reply other threads:[~2004-10-20 8:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-20 7:08 [PATCH] Fix PREEMPT_ACTIVE definition Paul Mackerras
2004-10-20 8:33 ` Ingo Molnar [this message]
2004-10-20 8:42 ` New consolidate irqs vs . probe_irq_*() Benjamin Herrenschmidt
2004-10-20 8:48 ` Ingo Molnar
2004-10-20 8:53 ` Benjamin Herrenschmidt
2004-10-20 9:20 ` Ingo Molnar
2004-10-20 10:56 ` Benjamin Herrenschmidt
2004-10-20 9:31 ` Chris Wedgwood
2004-10-20 9:01 ` Russell King
2004-10-20 10:50 ` Benjamin Herrenschmidt
2004-10-20 11:01 ` Russell King
2004-10-20 11:06 ` Benjamin Herrenschmidt
2004-10-20 11:53 ` Paul Mackerras
2004-10-20 12:31 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041020083358.GB23396@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=anton@samba.org \
--cc=benh@kernel.crashing.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.