All of lore.kernel.org
 help / color / mirror / Atom feed
From: maximilian attems <janitor@sternwelten.at>
To: Hanna Linder <hannal@us.ibm.com>
Cc: kernel-janitors@lists.osdl.org, greg@kroah.com,
	linux-kernel@vger.kernel.org, perex@suse.cz,
	sailer@ife.ee.ethz.ch
Subject: Re: [KJ] [PATCH 2.6.9-rc2-mm4 cmipci.c] [8/8]	Replace pci_find_device
Date: Thu, 21 Oct 2004 00:01:00 +0000	[thread overview]
Message-ID: <20041021000100.GE1953@stro.at> (raw)
In-Reply-To: <32220000.1098313960@w-hlinder.beaverton.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 801 bytes --]

hello hanna,

On Wed, 20 Oct 2004, Hanna Linder wrote:

> --On Thursday, October 21, 2004 01:01:28 AM +0200 maximilian attems <janitor@sternwelten.at> wrote:
> 
> >> +		if (!pci_dev_present(intel_82437vx)) 
> >                                                     ^
> >>  			snd_cmipci_set_bit(cm, CM_REG_MISC_CTRL, CM_TXVX);
> >>  		break;
> >>  	default:
> >> 
> >> 
> > 
> > a second one with small whitespace damage.
> > fixed for next kjt.
> 
> Hi Max,
> 
> According to the CodingStyle I should not put a white space
> after the function name and before the parenthesis. 
> 
> I do not believe that should be added.
> 
> Thanks.
> 
> Hanna

agreed.

sorry for being unclear,
i meant newly introduced trailing whitespace in both cases.

--
maks
kernel janitor  	http://janitor.kernelnewbies.org/


[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

WARNING: multiple messages have this Message-ID (diff)
From: maximilian attems <janitor@sternwelten.at>
To: Hanna Linder <hannal@us.ibm.com>
Cc: kernel-janitors@lists.osdl.org, greg@kroah.com,
	linux-kernel@vger.kernel.org, perex@suse.cz,
	sailer@ife.ee.ethz.ch
Subject: Re: [KJ]  [PATCH 2.6.9-rc2-mm4 cmipci.c] [8/8]	Replace pci_find_device with pci_dev_present
Date: Thu, 21 Oct 2004 02:01:00 +0200	[thread overview]
Message-ID: <20041021000100.GE1953@stro.at> (raw)
In-Reply-To: <32220000.1098313960@w-hlinder.beaverton.ibm.com>

hello hanna,

On Wed, 20 Oct 2004, Hanna Linder wrote:

> --On Thursday, October 21, 2004 01:01:28 AM +0200 maximilian attems <janitor@sternwelten.at> wrote:
> 
> >> +		if (!pci_dev_present(intel_82437vx)) 
> >                                                     ^
> >>  			snd_cmipci_set_bit(cm, CM_REG_MISC_CTRL, CM_TXVX);
> >>  		break;
> >>  	default:
> >> 
> >> 
> > 
> > a second one with small whitespace damage.
> > fixed for next kjt.
> 
> Hi Max,
> 
> According to the CodingStyle I should not put a white space
> after the function name and before the parenthesis. 
> 
> I do not believe that should be added.
> 
> Thanks.
> 
> Hanna

agreed.

sorry for being unclear,
i meant newly introduced trailing whitespace in both cases.

--
maks
kernel janitor  	http://janitor.kernelnewbies.org/


  reply	other threads:[~2004-10-21  0:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-30  0:08 [Kernel-janitors] [PATCH 2.6.9-rc2-mm4 cmipci.c] [8/8] Replace Hanna Linder
2004-09-30  0:08 ` [PATCH 2.6.9-rc2-mm4 cmipci.c] [8/8] Replace pci_find_device with pci_dev_present Hanna Linder
2004-10-20 23:01 ` [KJ] Re: [Kernel-janitors] [PATCH 2.6.9-rc2-mm4 cmipci.c] [8/8] maximilian attems
2004-10-20 23:01   ` [Kernel-janitors] [PATCH 2.6.9-rc2-mm4 cmipci.c] [8/8] Replace pci_find_device with pci_dev_present maximilian attems
2004-10-20 23:12   ` [KJ] Re: [Kernel-janitors] [PATCH 2.6.9-rc2-mm4 cmipci.c] Hanna Linder
2004-10-20 23:12     ` [KJ] Re: [Kernel-janitors] [PATCH 2.6.9-rc2-mm4 cmipci.c] [8/8] Replace pci_find_device with pci_dev_present Hanna Linder
2004-10-21  0:01     ` maximilian attems [this message]
2004-10-21  0:01       ` [KJ] " maximilian attems

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041021000100.GE1953@stro.at \
    --to=janitor@sternwelten.at \
    --cc=greg@kroah.com \
    --cc=hannal@us.ibm.com \
    --cc=kernel-janitors@lists.osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@suse.cz \
    --cc=sailer@ife.ee.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.