* [KJ] block/pktcdvd: set_current_state() location
@ 2004-10-22 21:38 Nishanth Aravamudan
0 siblings, 0 replies; only message in thread
From: Nishanth Aravamudan @ 2004-10-22 21:38 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 476 bytes --]
Jens & Peter,
I was looking through 2.6.9-bk7 with the latest kjt (Kernel-Janitors
patchset) applied and noticed a new schedule_timeout() in the code. In
drivers/block/pktcdvd.c::kcdrwd(), the state is set at the head of the
for(;;)-loop, while the sleeping doesn't occur until nearly the end of
the same loop. Is there a reason for the code in-between to run in
TASK_INTERRUPTIBLE? If not, then would it make sense to use
msleep_interruptible? Thanks for your input.
-Nish
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-10-22 21:38 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-10-22 21:38 [KJ] block/pktcdvd: set_current_state() location Nishanth Aravamudan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.