All of lore.kernel.org
 help / color / mirror / Atom feed
* [uml-devel] Unknown symbols
@ 2004-10-22 19:16 Bodo Stroesser
  2004-10-23  1:16 ` [uml-devel] " BlaisorBlade
  0 siblings, 1 reply; 4+ messages in thread
From: Bodo Stroesser @ 2004-10-22 19:16 UTC (permalink / raw)
  To: user-mode-linux-devel; +Cc: Jeff Dike, BlaisorBlade

Building 2.6.9 with vsyscall, I got problems with unknown symbols, e.g:

     ext3: Unknown symbol vsyscall_end
     ext3: Unknown symbol vsyscall_ehdr

for (almost) all modules, my current config uses.
The same problem exists for "end_iomem", but in the modules xfs.ko and ntfs.ko only.

I tried to fix that for the vsyscall_xxx in arch/um/os-Linux/elf_aux.c. I inserted
EXPORT_SYMBOLS for them, but it failed to compile, because it's not possible to
include "linux/module.h" in this user-code module.

What should I do to fix this? Move the variables to a kernel-source-file?
Or moving the EXPORTs only? To what file do you think that it should be moved?

For end_iomem inserting a EXPORT_SYMBOLS in arch/um/kernel/um_arch.c seems to be
enough.

Bodo


-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [uml-devel] Re: Unknown symbols
  2004-10-22 19:16 [uml-devel] Unknown symbols Bodo Stroesser
@ 2004-10-23  1:16 ` BlaisorBlade
  2004-10-23  3:09   ` Jeff Dike
  0 siblings, 1 reply; 4+ messages in thread
From: BlaisorBlade @ 2004-10-23  1:16 UTC (permalink / raw)
  To: Bodo Stroesser; +Cc: user-mode-linux-devel, Jeff Dike

On Friday 22 October 2004 21:16, Bodo Stroesser wrote:
> Building 2.6.9 with vsyscall, I got problems with unknown symbols, e.g:

>      ext3: Unknown symbol vsyscall_end
>      ext3: Unknown symbol vsyscall_ehdr

> for (almost) all modules, my current config uses.
> The same problem exists for "end_iomem", but in the modules xfs.ko and
> ntfs.ko only.

> I tried to fix that for the vsyscall_xxx in arch/um/os-Linux/elf_aux.c. I
> inserted EXPORT_SYMBOLS for them, but it failed to compile, because it's
> not possible to include "linux/module.h" in this user-code module.

> What should I do to fix this? Move the variables to a kernel-source-file?
> Or moving the EXPORTs only? To what file do you think that it should be
> moved?

The EXPORT_SYMBOL can be in any kernel space file, if you have declared the 
function before.

Since the functions are in arch/um/os-Linux, they could go in 
arch/um/os-Linux/user_syms.c.

In general, if you have a kernelspace file related to the userspace file, you 
put the EXPORT_SYMBOLS in the kernel-space file.

> For end_iomem inserting a EXPORT_SYMBOLS in arch/um/kernel/um_arch.c seems
> to be enough.

Yes, I guess. Send the resulting patch to Jeff - as a separate one.
-- 
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729


-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [uml-devel] Re: Unknown symbols
  2004-10-23  1:16 ` [uml-devel] " BlaisorBlade
@ 2004-10-23  3:09   ` Jeff Dike
  2004-10-25 14:10     ` Bodo Stroesser
  0 siblings, 1 reply; 4+ messages in thread
From: Jeff Dike @ 2004-10-23  3:09 UTC (permalink / raw)
  To: BlaisorBlade; +Cc: Bodo Stroesser, user-mode-linux-devel

On Sat, Oct 23, 2004 at 03:16:16AM +0200, BlaisorBlade wrote:
> > For end_iomem inserting a EXPORT_SYMBOLS in arch/um/kernel/um_arch.c seems
> > to be enough.
> 
> Yes, I guess. Send the resulting patch to Jeff - as a separate one.

Those are userspace things, so they go in user_syms.c - that already has the
export crap copied into it.

				Jeff


-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [uml-devel] Re: Unknown symbols
  2004-10-23  3:09   ` Jeff Dike
@ 2004-10-25 14:10     ` Bodo Stroesser
  0 siblings, 0 replies; 4+ messages in thread
From: Bodo Stroesser @ 2004-10-25 14:10 UTC (permalink / raw)
  To: Jeff Dike; +Cc: BlaisorBlade, user-mode-linux-devel

Jeff Dike wrote:
> On Sat, Oct 23, 2004 at 03:16:16AM +0200, BlaisorBlade wrote:
> 
>>>For end_iomem inserting a EXPORT_SYMBOLS in arch/um/kernel/um_arch.c seems
>>>to be enough.
>>
>>Yes, I guess. Send the resulting patch to Jeff - as a separate one.
> 
> 
> Those are userspace things, so they go in user_syms.c - that already has the
> export crap copied into it.
> 
> 				Jeff
OK. Here is the first patch. It handles end_iomem only. Since end_iomem is
located in arch_um.c, I prefered to put the EXPORT_SYMBOL into ksyms.c.

I hope, you agree.

The EXPORTs for vsyscall_* are included in a separate patch. It's mailed in
the vsyscall-thread, because it includes some improvement for vsyscall also.

---

diff -puNr a/arch/um/kernel/ksyms.c b/arch/um/kernel/ksyms.c
--- a/arch/um/kernel/ksyms.c	2004-10-18 23:53:08.000000000 +0200
+++ b/arch/um/kernel/ksyms.c	2004-10-25 14:23:32.811120267 +0200
@@ -48,6 +48,7 @@ EXPORT_SYMBOL(to_virt);
  EXPORT_SYMBOL(mode_tt);
  EXPORT_SYMBOL(handle_page_fault);
  EXPORT_SYMBOL(find_iomem);
+EXPORT_SYMBOL(end_iomem);

  #ifdef CONFIG_MODE_TT
  EXPORT_SYMBOL(strncpy_from_user_tt);


-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2004-10-25 14:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-10-22 19:16 [uml-devel] Unknown symbols Bodo Stroesser
2004-10-23  1:16 ` [uml-devel] " BlaisorBlade
2004-10-23  3:09   ` Jeff Dike
2004-10-25 14:10     ` Bodo Stroesser

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.