From: Christoph Hellwig <hch@lst.de>
To: Doug Maxey <dwm@austin.ibm.com>
Cc: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>,
Paul Mackerras <paulus@samba.org>,
Greg Kroah-Hartman <greg@kroah.com>,
Linux SCSI Mailing List <linux-scsi@vger.kernel.org>,
Linux IDE Mailing List <linux-ide@vger.kernel.org>,
linuxppc64-dev@ozlabs.org
Subject: Re: [PATCH 1/1] build modular usb isd200 with modular ide
Date: Sun, 24 Oct 2004 12:03:19 +0200 [thread overview]
Message-ID: <20041024100319.GA17183@lst.de> (raw)
In-Reply-To: <200410240055.i9O0taCf006206@falcon10.austin.ibm.com>
On Sat, Oct 23, 2004 at 07:55:36PM -0500, Doug Maxey wrote:
>
> Name: inline ide_fix_driveid()
>
> Rationale:
> This is a fix for bugme.osdl 3819.
bugme.osdl.org doesn't know of a bug #3819.
> With any of the 2.6.9 release flavors (vanilla, mm1, ac3), one
> cannot build the usb isd200 module due to the dependency on
> ide_fix_driveid() being exported from ide-iops.
>
> Description:
> When building IDE modular, the current ide_fix_driveid() is
> exported from ide-iops.c. This patch makes the function an inline.
Still doesn't make any sense. ide_fix_driveid is properly exported from
ide-iops.c, so you use it from other modules. The only case that
doesn't work is modular ide and builtin usb-storage, and the BLK_DEV_IDE
depency should fix that one.
If you think that depency is ugly (I do) just copy the routine to
isd200.c, it's a) too large to inline but b) just a trivial byteswap
that should need much changes over time.
next prev parent reply other threads:[~2004-10-24 10:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-24 0:55 [PATCH 1/1] build modular usb isd200 with modular ide Doug Maxey
2004-10-24 10:03 ` Christoph Hellwig [this message]
2004-10-24 12:45 ` Bartlomiej Zolnierkiewicz
2004-10-25 22:55 ` Doug Maxey
2004-10-25 23:12 ` Paul Mackerras
2004-10-25 23:55 ` Doug Maxey
2004-10-26 2:05 ` Paul Mackerras
2004-10-26 18:05 ` Doug Maxey
2004-10-25 23:20 ` Bartlomiej Zolnierkiewicz
2004-10-24 23:11 ` Doug Maxey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041024100319.GA17183@lst.de \
--to=hch@lst.de \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=dwm@austin.ibm.com \
--cc=greg@kroah.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc64-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.