From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Doug Maxey <dwm@austin.ibm.com>
Cc: Christoph Hellwig <hch@lst.de>, Paul Mackerras <paulus@samba.org>,
Greg Kroah-Hartman <greg@kroah.com>,
Linux SCSI Mailing List <linux-scsi@vger.kernel.org>,
Linux IDE Mailing List <linux-ide@vger.kernel.org>,
linuxppc64-dev@ozlabs.org
Subject: Re: [PATCH 1/1] build modular usb isd200 with modular ide
Date: Tue, 26 Oct 2004 01:20:08 +0200 [thread overview]
Message-ID: <58cb370e0410251620279fb0ee@mail.gmail.com> (raw)
In-Reply-To: <200410252255.i9PMto6B024865@falcon10.austin.ibm.com>
On Mon, 25 Oct 2004 17:55:50 -0500, Doug Maxey <dwm@austin.ibm.com> wrote:
> >The dependency is a bug, <linux/ide.h> is for IDE driver only.
>
> The isd200 _is_ a bridge to ATA/ATAPI devices. Does this mean it cannot use
> common code, just because it is not in drivers/ide?
no but the common ATA/ATAPI code resides in hdreg.h or/and ata.h,
ide.h is for IDE driver _only_
> >Doug, if you kill debugging code in isd200.c then only:
> >
> >id->command_set_1
> >id->model
> >id->fw_rev
> >id->capability
> >id->lba_capacity
> >id->heads
> >id->cyls
> >id->sectors
> >id->command_set_2
> >
> >need to be byte-swapped.
> >
>
> I don't plan on killing any debug code.
I do :)
next prev parent reply other threads:[~2004-10-26 1:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-24 0:55 [PATCH 1/1] build modular usb isd200 with modular ide Doug Maxey
2004-10-24 10:03 ` Christoph Hellwig
2004-10-24 12:45 ` Bartlomiej Zolnierkiewicz
2004-10-25 22:55 ` Doug Maxey
2004-10-25 23:12 ` Paul Mackerras
2004-10-25 23:55 ` Doug Maxey
2004-10-26 2:05 ` Paul Mackerras
2004-10-26 18:05 ` Doug Maxey
2004-10-25 23:20 ` Bartlomiej Zolnierkiewicz [this message]
2004-10-24 23:11 ` Doug Maxey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58cb370e0410251620279fb0ee@mail.gmail.com \
--to=bzolnier@gmail.com \
--cc=dwm@austin.ibm.com \
--cc=greg@kroah.com \
--cc=hch@lst.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc64-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.