All of lore.kernel.org
 help / color / mirror / Atom feed
* [KJ] [PATCH] message/mptbase: replace schedule_timeout() with
@ 2004-10-22 23:30 Nishanth Aravamudan
  2004-10-24 14:09 ` maximilian attems
  0 siblings, 1 reply; 2+ messages in thread
From: Nishanth Aravamudan @ 2004-10-22 23:30 UTC (permalink / raw)
  To: kernel-janitors

[-- Attachment #1: Type: text/plain, Size: 682 bytes --]

Any comments would be, as always, appreciated.

-Nish

Description: Uses msleep_interruptible() instead of schedule_timeout()
to guarantee the task delays as expected.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>

--- 2.6.9-bk7-vanilla/drivers/message/fusion/mptbase.c	2004-10-22 10:41:45.000000000 -0700
+++ 2.6.9-bk7/drivers/message/fusion/mptbase.c	2004-10-22 14:54:57.000000000 -0700
@@ -3171,8 +3171,7 @@ mpt_diag_reset(MPT_ADAPTER *ioc, int ign
 
 				/* wait 1 sec */
 				if (sleepFlag == CAN_SLEEP) {
-					set_current_state(TASK_INTERRUPTIBLE);
-					schedule_timeout(1000 * HZ / 1000);
+					msleep_interruptible(1000);
 				} else {
 					mdelay (1000);
 				}

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [KJ] [PATCH] message/mptbase: replace schedule_timeout() with
  2004-10-22 23:30 [KJ] [PATCH] message/mptbase: replace schedule_timeout() with Nishanth Aravamudan
@ 2004-10-24 14:09 ` maximilian attems
  0 siblings, 0 replies; 2+ messages in thread
From: maximilian attems @ 2004-10-24 14:09 UTC (permalink / raw)
  To: kernel-janitors

[-- Attachment #1: Type: text/plain, Size: 376 bytes --]

On Fri, 22 Oct 2004, Nishanth Aravamudan wrote:

> Any comments would be, as always, appreciated.
> 
> -Nish
> 
> Description: Uses msleep_interruptible() instead of schedule_timeout()
> to guarantee the task delays as expected.
> 
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
> 
applied to kjt,
to get further testing and to be shure it gets upstream.

thanks maks

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-10-24 14:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-10-22 23:30 [KJ] [PATCH] message/mptbase: replace schedule_timeout() with Nishanth Aravamudan
2004-10-24 14:09 ` maximilian attems

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.