[KJ] [PATCH] video/pxafb: reorder add_wait_queue() and

[KJ] [PATCH] video/pxafb: reorder add_wait_queue() and

[Nishanth Aravamudan]

[-- Attachment #1: Type: text/plain, Size: 766 bytes --]

Any comments would be, as always, appreciated.

-Nish

Description: Reorder set_current_state() and add_wait_queue(). There is
a chance that a signal could be missed in between the two functions
currently.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>

--- 2.6.9-bk7-vanilla/drivers/video/pxafb.c	2004-10-22 10:40:44.000000000 -0700
+++ 2.6.9-bk7/drivers/video/pxafb.c	2004-10-22 15:59:23.000000000 -0700
@@ -741,8 +741,8 @@ static void pxafb_disable_controller(str
 
 	DPRINTK("Disabling LCD controller\n");
 
-	add_wait_queue(&fbi->ctrlr_wait, &wait);
 	set_current_state(TASK_UNINTERRUPTIBLE);
+	add_wait_queue(&fbi->ctrlr_wait, &wait);
 
 	LCSR = 0xffffffff;	/* Clear LCD Status Register */
 	LCCR0 &= ~LCCR0_LDM;	/* Enable LCD Disable Done Interrupt */

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] video/pxafb: reorder add_wait_queue() and

[maximilian attems]

[-- Attachment #1: Type: text/plain, Size: 471 bytes --]

On Fri, 22 Oct 2004, Nishanth Aravamudan wrote:

> Any comments would be, as always, appreciated.
> 
> -Nish
> 
> Description: Reorder set_current_state() and add_wait_queue(). There is
> a chance that a signal could be missed in between the two functions
> currently.
> 
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>

applied to kjt,
to get further testing and to be shure it gets upstream.

thanks 

--
maks
kernel janitor  	http://janitor.kernelnewbies.org/


[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors