* [KJ] [PATCH] pci/quirks: replace schedule_timeout() with msleep()
@ 2004-10-22 23:54 Nishanth Aravamudan
2004-10-24 14:10 ` maximilian attems
0 siblings, 1 reply; 2+ messages in thread
From: Nishanth Aravamudan @ 2004-10-22 23:54 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 922 bytes --]
Any comments would be, as always, appreciated.
-Nish
Description: Use msleep() instead of schedule_timeout() to guarantee the
task delays as expected.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- 2.6.9-bk7-vanilla/drivers/pci/quirks.c 2004-10-22 10:40:52.000000000 -0700
+++ 2.6.9-bk7/drivers/pci/quirks.c 2004-10-22 15:17:43.000000000 -0700
@@ -938,8 +938,7 @@ static void __devinit quirk_usb_handoff_
while (wait_time > 0 &&
readl(base + OHCI_CONTROL) & OHCI_CTRL_IR) {
wait_time -= 10;
- set_current_state(TASK_UNINTERRUPTIBLE);
- schedule_timeout((HZ*10 + 999) / 1000);
+ msleep(10);
}
}
@@ -988,8 +987,7 @@ static void __devinit quirk_usb_disable_
wait_time = 500;
do {
- set_current_state(TASK_UNINTERRUPTIBLE);
- schedule_timeout((HZ*10+999)/1000);
+ msleep(10);
wait_time -= 10;
pci_read_config_dword(pdev,
hcc_params + EHCI_USBLEGSUP,
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-10-24 14:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-10-22 23:54 [KJ] [PATCH] pci/quirks: replace schedule_timeout() with msleep() Nishanth Aravamudan
2004-10-24 14:10 ` maximilian attems
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.