* socket.h patch (SOCK_XXX break glibc build)
@ 2004-10-26 1:12 Atsushi Nemoto
2004-10-26 1:50 ` Ralf Baechle
0 siblings, 1 reply; 4+ messages in thread
From: Atsushi Nemoto @ 2004-10-26 1:12 UTC (permalink / raw)
To: linux-mips; +Cc: ralf
On 2.6.9, SOCK_DGRAM, etc. in asm-mips/socket.h are visible from
userland. It will break glibc build. For other archs,
include/linux/net.h uses "#ifdef __KERNEL__" for SOCK_XXX definitions,
so asm-mips/socket.h should use "#ifdef __KERNEL__" too?
diff -u linux-mips/include/asm-mips/socket.h linux/include/asm-mips/
--- linux-mips/include/asm-mips/socket.h Thu Oct 21 09:39:03 2004
+++ linux/include/asm-mips/socket.h Mon Oct 25 22:06:43 2004
@@ -68,6 +68,8 @@
#define SO_PEERSEC 30
+#ifdef __KERNEL__
+:
/** sock_type - Socket types
*
* Please notice that for binary compat reasons MIPS has to
@@ -95,4 +97,6 @@
#define ARCH_HAS_SOCKET_TYPES 1
+#endif /* __KERNEL__ */
+
#endif /* _ASM_SOCKET_H */
---
Atsushi Nemoto
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: socket.h patch (SOCK_XXX break glibc build)
2004-10-26 1:12 socket.h patch (SOCK_XXX break glibc build) Atsushi Nemoto
@ 2004-10-26 1:50 ` Ralf Baechle
2004-10-26 10:30 ` Atsushi Nemoto
0 siblings, 1 reply; 4+ messages in thread
From: Ralf Baechle @ 2004-10-26 1:50 UTC (permalink / raw)
To: Atsushi Nemoto; +Cc: linux-mips
On Tue, Oct 26, 2004 at 10:12:26AM +0900, Atsushi Nemoto wrote:
> On 2.6.9, SOCK_DGRAM, etc. in asm-mips/socket.h are visible from
> userland. It will break glibc build. For other archs,
> include/linux/net.h uses "#ifdef __KERNEL__" for SOCK_XXX definitions,
> so asm-mips/socket.h should use "#ifdef __KERNEL__" too?
Ok ...
Ralf
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: socket.h patch (SOCK_XXX break glibc build)
2004-10-26 1:50 ` Ralf Baechle
@ 2004-10-26 10:30 ` Atsushi Nemoto
2004-10-26 10:37 ` Ralf Baechle
0 siblings, 1 reply; 4+ messages in thread
From: Atsushi Nemoto @ 2004-10-26 10:30 UTC (permalink / raw)
To: ralf; +Cc: linux-mips
>>>>> On Tue, 26 Oct 2004 03:50:36 +0200, Ralf Baechle <ralf@linux-mips.org> said:
>> On 2.6.9, SOCK_DGRAM, etc. in asm-mips/socket.h are visible from
>> userland. It will break glibc build. For other archs,
>> include/linux/net.h uses "#ifdef __KERNEL__" for SOCK_XXX
>> definitions, so asm-mips/socket.h should use "#ifdef __KERNEL__"
>> too?
ralf> Ok ...
Sorry, there was a garbage character (':') in my patch. Please remove
it. Thank you.
> @@ -68,6 +68,8 @@
>
> #define SO_PEERSEC 30
>
> +#ifdef __KERNEL__
> +:
> /** sock_type - Socket types
> *
> * Please notice that for binary compat reasons MIPS has to
---
Atsushi Nemoto
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2004-10-26 10:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-10-26 1:12 socket.h patch (SOCK_XXX break glibc build) Atsushi Nemoto
2004-10-26 1:50 ` Ralf Baechle
2004-10-26 10:30 ` Atsushi Nemoto
2004-10-26 10:37 ` Ralf Baechle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.