All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: Chris Wedgwood <cw@f00f.org>
Cc: Jeff Garzik <jgarzik@pobox.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: Re: [RFC] Rename SECTOR_SIZE to IDE_SECTOR_SIZE
Date: Wed, 27 Oct 2004 09:22:12 +0200	[thread overview]
Message-ID: <20041027072212.GN15910@suse.de> (raw)
In-Reply-To: <20041027065524.GA1524@taniwha.stupidest.org>

On Tue, Oct 26 2004, Chris Wedgwood wrote:
> On Wed, Oct 27, 2004 at 02:47:51AM -0400, Jeff Garzik wrote:
> 
> > It's highly silly to rename the same name + the same value to
> > multiple different names.
> 
> initially i was going to do that, but when i looked at the code i
> realized the problem is some of the users seem to be semantically
> different and potentially might want to be changed separate to the
> others
> 
> > Put it in a common header somewhere, and only rename the oddballs
> > (if any).
> 
> we could have UNIX_SECTOR_SIZE in blkdev.h but as i said, some users
> really are 512 for different reasons that might change (?)

Please, just call it IO_SECTOR_SIZE or BIO_SECTOR_SIZE to signify that
it's the block io sector size. And use that where it applies, leave the
rest of the unrelated cases alone.

-- 
Jens Axboe


  reply	other threads:[~2004-10-27  7:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-27  6:08 [RFC] Rename SECTOR_SIZE to IDE_SECTOR_SIZE Chris Wedgwood
2004-10-27  6:47 ` Jeff Garzik
2004-10-27  6:55   ` Chris Wedgwood
2004-10-27  7:22     ` Jens Axboe [this message]
2004-10-27 19:05       ` [PATCH] Rename SECTOR_SIZE to BIO_SECTOR_SIZE Chris Wedgwood
2004-10-27 20:27         ` Matt Mackall
2004-10-27 20:29           ` Chris Wedgwood
2004-10-27 20:36             ` Bartlomiej Zolnierkiewicz
2004-10-27 20:45           ` J.A. Magallon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041027072212.GN15910@suse.de \
    --to=axboe@suse.de \
    --cc=bzolnier@gmail.com \
    --cc=cw@f00f.org \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.