All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Chris Wedgwood <cw@f00f.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Chris Wedgwood <cw@taniwha.stupidest.org>,
	Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: Re: [RFC] Rename SECTOR_SIZE to IDE_SECTOR_SIZE
Date: Wed, 27 Oct 2004 02:47:51 -0400	[thread overview]
Message-ID: <417F4497.3020205@pobox.com> (raw)
In-Reply-To: <20041027060828.GA32396@taniwha.stupidest.org>

Chris Wedgwood wrote:
> The token SECTOR_SIZE is used in multiple places that have (almost)
> the same defintion everywhere.
> 
> How do people feel about rename this vague token?

It's highly silly to rename the same name + the same value to multiple 
different names.

Put it in a common header somewhere, and only rename the oddballs (if any).

	Jeff




  reply	other threads:[~2004-10-27  6:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-27  6:08 [RFC] Rename SECTOR_SIZE to IDE_SECTOR_SIZE Chris Wedgwood
2004-10-27  6:47 ` Jeff Garzik [this message]
2004-10-27  6:55   ` Chris Wedgwood
2004-10-27  7:22     ` Jens Axboe
2004-10-27 19:05       ` [PATCH] Rename SECTOR_SIZE to BIO_SECTOR_SIZE Chris Wedgwood
2004-10-27 20:27         ` Matt Mackall
2004-10-27 20:29           ` Chris Wedgwood
2004-10-27 20:36             ` Bartlomiej Zolnierkiewicz
2004-10-27 20:45           ` J.A. Magallon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=417F4497.3020205@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=bzolnier@gmail.com \
    --cc=cw@f00f.org \
    --cc=cw@taniwha.stupidest.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.