* Problem with module parameters and sysfs
@ 2004-10-27 6:43 Dmitry Torokhov
2004-10-27 8:58 ` Dominik Brodowski
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Torokhov @ 2004-10-27 6:43 UTC (permalink / raw)
To: Rusty Russell, Dominik Brodowski; +Cc: LKML
Hi,
It seems that the following patch
http://linux.bkbits.net:8080/linux-2.5/diffs/kernel/params.c%401.12?nav=index.html|ChangeSet@-3d|cset@1.2142
broke module parameters in sysfs for the case when driver is built
as a module:
[root@core dtor]# ls -la /sys/module/i8042/
total 0
drwxr-xr-x 3 root root 0 Oct 26 19:20 .
drwxr-xr-x 54 root root 0 Oct 27 00:28 ..
drwxr-xr-x 2 root root 0 Oct 26 19:20 parameters
[root@core dtor]# ls -la /sys/module/psmouse/
total 0
drwxr-xr-x 3 root root 0 Oct 27 00:21 .
drwxr-xr-x 54 root root 0 Oct 27 00:28 ..
-r--r--r-- 1 root root 4096 Oct 27 00:21 refcnt
drwxr-xr-x 2 root root 0 Oct 27 00:21 sections
psmouse is built as a module while i8042 is compiled in.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Problem with module parameters and sysfs
2004-10-27 6:43 Problem with module parameters and sysfs Dmitry Torokhov
@ 2004-10-27 8:58 ` Dominik Brodowski
2004-10-27 13:27 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Dominik Brodowski @ 2004-10-27 8:58 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: Rusty Russell, LKML
On Wed, Oct 27, 2004 at 01:43:54AM -0500, Dmitry Torokhov wrote:
> Hi,
>
> It seems that the following patch
>
> http://linux.bkbits.net:8080/linux-2.5/diffs/kernel/params.c%401.12?nav=index.html|ChangeSet@-3d|cset@1.2142
>
> broke module parameters in sysfs for the case when driver is built
> as a module:
>
> [root@core dtor]# ls -la /sys/module/i8042/
> total 0
> drwxr-xr-x 3 root root 0 Oct 26 19:20 .
> drwxr-xr-x 54 root root 0 Oct 27 00:28 ..
> drwxr-xr-x 2 root root 0 Oct 26 19:20 parameters
>
> [root@core dtor]# ls -la /sys/module/psmouse/
> total 0
> drwxr-xr-x 3 root root 0 Oct 27 00:21 .
> drwxr-xr-x 54 root root 0 Oct 27 00:28 ..
> -r--r--r-- 1 root root 4096 Oct 27 00:21 refcnt
> drwxr-xr-x 2 root root 0 Oct 27 00:21 sections
>
> psmouse is built as a module while i8042 is compiled in.
All module_params I can see in psmouse have permission "0", so they don't
need to be exported in sysfs. Or am I missing something here?
Thanks,
Dominik
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Problem with module parameters and sysfs
2004-10-27 8:58 ` Dominik Brodowski
@ 2004-10-27 13:27 ` Dmitry Torokhov
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2004-10-27 13:27 UTC (permalink / raw)
To: Dominik Brodowski; +Cc: Rusty Russell, LKML
On Wednesday 27 October 2004 03:58 am, Dominik Brodowski wrote:
> On Wed, Oct 27, 2004 at 01:43:54AM -0500, Dmitry Torokhov wrote:
> > total 0
> > drwxr-xr-x 3 root root 0 Oct 27 00:21 .
> > drwxr-xr-x 54 root root 0 Oct 27 00:28 ..
> > -r--r--r-- 1 root root 4096 Oct 27 00:21 refcnt
> > drwxr-xr-x 2 root root 0 Oct 27 00:21 sections
> >
> > psmouse is built as a module while i8042 is compiled in.
>
> All module_params I can see in psmouse have permission "0", so they don't
> need to be exported in sysfs. Or am I missing something here?
>
Ahem... Hand me that paper bag please...
Sorry for the noise, I did not find the params directory and assumed that
something went wrong without even thinking about permissions.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-10-27 13:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-10-27 6:43 Problem with module parameters and sysfs Dmitry Torokhov
2004-10-27 8:58 ` Dominik Brodowski
2004-10-27 13:27 ` Dmitry Torokhov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.