From: Andrew Morton <akpm@osdl.org>
To: Greg KH <greg@kroah.com>
Cc: dsaxena@plexity.net, torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Remove inclusion of <linux/irq.h> from pci/quirks.c
Date: Thu, 28 Oct 2004 14:37:53 -0700 [thread overview]
Message-ID: <20041028143753.338c1b7e.akpm@osdl.org> (raw)
In-Reply-To: <20041028211432.GB9369@kroah.com>
Greg KH <greg@kroah.com> wrote:
>
> > Also, it worries me that quirk_intel_irqbalance() is marked __devinit and
> > calls irqbalance_disable(), which is marked __init. I guess a fix for that
> > would be to mark quirk_intel_irqbalance() as __init, since it's unlikely to
> > be called after free_initmem(). Does Greg agree?
>
> I do agree. But I think the intel people are mucking around in this
> area too and hopefully they'll fix it all up soon...
It should all be fixed up now. We moved the intel-specific quirk to the
new arch/i386/kernel/quirks.c.
prev parent reply other threads:[~2004-10-28 21:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-20 18:22 [PATCH] Remove inclusion of <linux/irq.h> from pci/quirks.c Deepak Saxena
2004-10-21 4:57 ` Andrew Morton
2004-10-28 21:14 ` Greg KH
2004-10-28 21:37 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041028143753.338c1b7e.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=dsaxena@plexity.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.