From: Greg KH <greg@kroah.com>
To: Andrew Morton <akpm@osdl.org>
Cc: dsaxena@plexity.net, torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Remove inclusion of <linux/irq.h> from pci/quirks.c
Date: Thu, 28 Oct 2004 16:14:32 -0500 [thread overview]
Message-ID: <20041028211432.GB9369@kroah.com> (raw)
In-Reply-To: <20041020215750.3f3764e6.akpm@osdl.org>
On Wed, Oct 20, 2004 at 09:57:50PM -0700, Andrew Morton wrote:
> Deepak Saxena <dsaxena@plexity.net> wrote:
> >
> > <linux/irq.h> states:
> >
> > /*
> > * Please do not include this file in generic code. There is currently
> > * no requirement for any architecture to implement anything held
> > * within this file.
> > *
> > * Thanks. --rmk
> > */
> >
> > The latest update into pci/quirks.c did not follow this and breaks
> > building on ARM.
>
> But it does break building on x86, which might prove a tad unpopular.
>
> That x86 code shouldn't be in the generic PCI code at all, I guess. This
> patch move it into io_apic.c and appears to build OK. I'll play with it a
> bit more.
>
> Also, it worries me that quirk_intel_irqbalance() is marked __devinit and
> calls irqbalance_disable(), which is marked __init. I guess a fix for that
> would be to mark quirk_intel_irqbalance() as __init, since it's unlikely to
> be called after free_initmem(). Does Greg agree?
I do agree. But I think the intel people are mucking around in this
area too and hopefully they'll fix it all up soon...
thanks,
greg k-h
next prev parent reply other threads:[~2004-10-28 21:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-20 18:22 [PATCH] Remove inclusion of <linux/irq.h> from pci/quirks.c Deepak Saxena
2004-10-21 4:57 ` Andrew Morton
2004-10-28 21:14 ` Greg KH [this message]
2004-10-28 21:37 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041028211432.GB9369@kroah.com \
--to=greg@kroah.com \
--cc=akpm@osdl.org \
--cc=dsaxena@plexity.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.