All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dtor_core@ameritech.net>
To: linux-kernel@vger.kernel.org
Cc: "Randy.Dunlap" <rddunlap@osdl.org>,
	james4765@verizon.net, kernel-janitors@lists.osdl.org
Subject: Re: [KJ] [PATCH] floppy: change MODULE_PARM to module_param
Date: Sat, 30 Oct 2004 18:03:45 +0000	[thread overview]
Message-ID: <200410301303.45161.dtor_core@ameritech.net> (raw)
In-Reply-To: <4183BF5B.5000303@osdl.org>

On Saturday 30 October 2004 11:20 am, Randy.Dunlap wrote:
> james4765@verizon.net wrote:
> > Replace MODULE_PARM with module_param in drivers/block/floppy.c.  Compile tested.
> > 
> > Signed-off-by: James Nelson <james4765@gmail.com>
> > 
> > diff -urN --exclude='*~' linux-2.6.9-original/drivers/block/floppy.c linux-2.6.9/drivers/block/floppy.c
> > --- linux-2.6.9-original/drivers/block/floppy.c	2004-10-18 17:53:22.000000000 -0400
> > +++ linux-2.6.9/drivers/block/floppy.c	2004-10-30 09:16:04.856720081 -0400
> > @@ -180,6 +180,7 @@
> >  #include <linux/devfs_fs_kernel.h>
> >  #include <linux/device.h>
> >  #include <linux/buffer_head.h>	/* for invalidate_buffers() */
> > +#include <linux/moduleparam.h>
> >  
> >  /*
> >   * PS/2 floppies have much slower step rates than regular floppies.
> > @@ -4623,9 +4624,9 @@
> >  	wait_for_completion(&device_release);
> >  }
> >  
> > -MODULE_PARM(floppy, "s");
> > -MODULE_PARM(FLOPPY_IRQ, "i");
> > -MODULE_PARM(FLOPPY_DMA, "i");
> > +module_param(floppy, charp, 0);
> > +module_param(FLOPPY_IRQ, int, 0);
> > +module_param(FLOPPY_DMA, int, 0);
> >  MODULE_AUTHOR("Alain L. Knaff");
> >  MODULE_SUPPORTED_DEVICE("fd");
> >  MODULE_LICENSE("GPL");
> 
> Please check Andrew's 2.6.10-rc1-mm2 for a large MODULE_PARAM
> patch, and then convert drivers that are not yet converted...
> 
> http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.10-rc1/2.6.10-rc1-mm2/broken-out/convert-module_parm-to-module_param-family.patch
> 

Actually it would be nice if drivers were converted "intelligently"
instead of basic find-and-replace - I really find parameter names
like floppy.floppy= or floppy.floppy_dma= ugly.

-- 
Dmitry
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Torokhov <dtor_core@ameritech.net>
To: linux-kernel@vger.kernel.org
Cc: "Randy.Dunlap" <rddunlap@osdl.org>,
	james4765@verizon.net, kernel-janitors@lists.osdl.org
Subject: Re: [KJ] [PATCH] floppy: change MODULE_PARM to module_param in	drivers/block/floppy.c
Date: Sat, 30 Oct 2004 13:03:45 -0500	[thread overview]
Message-ID: <200410301303.45161.dtor_core@ameritech.net> (raw)
In-Reply-To: <4183BF5B.5000303@osdl.org>

On Saturday 30 October 2004 11:20 am, Randy.Dunlap wrote:
> james4765@verizon.net wrote:
> > Replace MODULE_PARM with module_param in drivers/block/floppy.c.  Compile tested.
> > 
> > Signed-off-by: James Nelson <james4765@gmail.com>
> > 
> > diff -urN --exclude='*~' linux-2.6.9-original/drivers/block/floppy.c linux-2.6.9/drivers/block/floppy.c
> > --- linux-2.6.9-original/drivers/block/floppy.c	2004-10-18 17:53:22.000000000 -0400
> > +++ linux-2.6.9/drivers/block/floppy.c	2004-10-30 09:16:04.856720081 -0400
> > @@ -180,6 +180,7 @@
> >  #include <linux/devfs_fs_kernel.h>
> >  #include <linux/device.h>
> >  #include <linux/buffer_head.h>	/* for invalidate_buffers() */
> > +#include <linux/moduleparam.h>
> >  
> >  /*
> >   * PS/2 floppies have much slower step rates than regular floppies.
> > @@ -4623,9 +4624,9 @@
> >  	wait_for_completion(&device_release);
> >  }
> >  
> > -MODULE_PARM(floppy, "s");
> > -MODULE_PARM(FLOPPY_IRQ, "i");
> > -MODULE_PARM(FLOPPY_DMA, "i");
> > +module_param(floppy, charp, 0);
> > +module_param(FLOPPY_IRQ, int, 0);
> > +module_param(FLOPPY_DMA, int, 0);
> >  MODULE_AUTHOR("Alain L. Knaff");
> >  MODULE_SUPPORTED_DEVICE("fd");
> >  MODULE_LICENSE("GPL");
> 
> Please check Andrew's 2.6.10-rc1-mm2 for a large MODULE_PARAM
> patch, and then convert drivers that are not yet converted...
> 
> http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.10-rc1/2.6.10-rc1-mm2/broken-out/convert-module_parm-to-module_param-family.patch
> 

Actually it would be nice if drivers were converted "intelligently"
instead of basic find-and-replace - I really find parameter names
like floppy.floppy= or floppy.floppy_dma= ugly.

-- 
Dmitry

  reply	other threads:[~2004-10-30 18:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-30 13:42 [KJ] [PATCH] floppy: change MODULE_PARM to module_param in james4765
2004-10-30 13:42 ` [PATCH] floppy: change MODULE_PARM to module_param in drivers/block/floppy.c james4765
2004-10-30 16:20 ` [KJ] [PATCH] floppy: change MODULE_PARM to module_param Randy.Dunlap
2004-10-30 16:20   ` [KJ] [PATCH] floppy: change MODULE_PARM to module_param in drivers/block/floppy.c Randy.Dunlap
2004-10-30 18:03   ` Dmitry Torokhov [this message]
2004-10-30 18:03     ` Dmitry Torokhov
2004-10-30 19:10     ` [KJ] [PATCH] floppy: change MODULE_PARM to module_param in Jim Nelson
2004-10-30 19:10       ` [KJ] [PATCH] floppy: change MODULE_PARM to module_param in drivers/block/floppy.c Jim Nelson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200410301303.45161.dtor_core@ameritech.net \
    --to=dtor_core@ameritech.net \
    --cc=james4765@verizon.net \
    --cc=kernel-janitors@lists.osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rddunlap@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.