[2.6 patch] let FW_LOADER select HOTPLUG

[2.6 patch] let FW_LOADER select HOTPLUG

[Adrian Bunk]

If it wasn't for external modules, FW_LOADER wasn't user-visible.
Let FW_LOADER select HOTPLUG To make the dependencies easier for users.


Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.10-rc1-mm2-full/drivers/base/Kconfig.old	2004-10-30 23:51:28.000000000 +0200
+++ linux-2.6.10-rc1-mm2-full/drivers/base/Kconfig	2004-10-30 23:51:40.000000000 +0200
@@ -20,7 +20,7 @@
 
 config FW_LOADER
 	tristate "Hotplug firmware loading support"
-	depends on HOTPLUG
+	select HOTPLUG
 	---help---
 	  This option is provided for the case where no in-kernel-tree modules
 	  require hotplug firmware loading support, but a module built outside
--- linux-2.6.10-rc1-mm2-full/drivers/net/wireless/Kconfig.old	2004-10-30 23:56:20.000000000 +0200
+++ linux-2.6.10-rc1-mm2-full/drivers/net/wireless/Kconfig	2004-10-30 23:56:39.000000000 +0200
@@ -309,9 +309,10 @@
 
 comment "Prism GT/Duette 802.11(a/b/g) PCI/Cardbus support"
 	depends on NET_RADIO && PCI
+
 config PRISM54
 	tristate 'Intersil Prism GT/Duette/Indigo PCI/Cardbus' 
-	depends on PCI && NET_RADIO && EXPERIMENTAL && HOTPLUG
+	depends on PCI && NET_RADIO && EXPERIMENTAL
 	select FW_LOADER
 	---help---
 	  Enable PCI and Cardbus support for the following chipset based cards:
--- linux-2.6.10-rc1-mm2-full/drivers/net/tokenring/Kconfig.old	2004-10-30 23:57:10.000000000 +0200
+++ linux-2.6.10-rc1-mm2-full/drivers/net/tokenring/Kconfig	2004-10-30 23:57:21.000000000 +0200
@@ -84,7 +84,7 @@
 
 config TMS380TR
 	tristate "Generic TMS380 Token Ring ISA/PCI adapter support"
-	depends on TR && (PCI || ISA) && HOTPLUG
+	depends on TR && (PCI || ISA)
 	select FW_LOADER
 	---help---
 	  This driver provides generic support for token ring adapters

Re: [2.6 patch] let FW_LOADER select HOTPLUG

[Russell King]

On Sun, Oct 31, 2004 at 12:03:09AM +0200, Adrian Bunk wrote:
> 
> If it wasn't for external modules, FW_LOADER wasn't user-visible.
> Let FW_LOADER select HOTPLUG To make the dependencies easier for users.

You know what I'm going to say about this patch, so I'll won't repeat,
except to say it has to do with select on user visible symbols.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core

Re: [2.6 patch] let FW_LOADER select HOTPLUG

[Adrian Bunk]

On Sat, Oct 30, 2004 at 11:11:56PM +0100, Russell King wrote:
> On Sun, Oct 31, 2004 at 12:03:09AM +0200, Adrian Bunk wrote:
> > 
> > If it wasn't for external modules, FW_LOADER wasn't user-visible.
> > Let FW_LOADER select HOTPLUG To make the dependencies easier for users.
> 
> You know what I'm going to say about this patch, so I'll won't repeat,
> except to say it has to do with select on user visible symbols.

I can send a patch that changes all dependencies on HOTPLUG to selects.
Would thids be acceptable?

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [2.6 patch] let FW_LOADER select HOTPLUG

[Russell King]

On Sun, Oct 31, 2004 at 12:18:41AM +0200, Adrian Bunk wrote:
> On Sat, Oct 30, 2004 at 11:11:56PM +0100, Russell King wrote:
> > On Sun, Oct 31, 2004 at 12:03:09AM +0200, Adrian Bunk wrote:
> > > 
> > > If it wasn't for external modules, FW_LOADER wasn't user-visible.
> > > Let FW_LOADER select HOTPLUG To make the dependencies easier for users.
> > 
> > You know what I'm going to say about this patch, so I'll won't repeat,
> > except to say it has to do with select on user visible symbols.
> 
> I can send a patch that changes all dependencies on HOTPLUG to selects.
> Would thids be acceptable?

Yup, especially as you can use the same argument as the FW_LOADER case
applies to the PCMCIA case, or PCI hotplug case.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core