* [PATCH 478] M68k SERIAL_PORT_DFNS only if CONFIG_ISA
@ 2004-10-31 10:03 Geert Uytterhoeven
2004-10-31 17:15 ` Russell King
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2004-10-31 10:03 UTC (permalink / raw)
To: Linus Torvalds, Andrew Morton
Cc: Linux Kernel Development, Geert Uytterhoeven
M68k serial: Only define SERIAL_PORT_DFNS when CONFIG_ISA is defined. Otherwise
the first 4 slots in the 8250 driver are unavailable on non-ISA machines.
(from Kars de Jong)
Signed-off-by: Kars de Jong <jongk@linux-m68k.org>
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
--- linux-2.6.10-rc1/include/asm-m68k/serial.h 2004-04-05 15:09:08.000000000 +0200
+++ linux-m68k-2.6.10-rc1/include/asm-m68k/serial.h 2004-07-14 13:19:48.000000000 +0200
@@ -74,6 +74,8 @@
#define EXTRA_SERIAL_PORT_DEFNS
#endif
+#ifdef CONFIG_ISA
#define SERIAL_PORT_DFNS \
STD_SERIAL_PORT_DEFNS \
EXTRA_SERIAL_PORT_DEFNS
+#endif
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 478] M68k SERIAL_PORT_DFNS only if CONFIG_ISA
2004-10-31 10:03 [PATCH 478] M68k SERIAL_PORT_DFNS only if CONFIG_ISA Geert Uytterhoeven
@ 2004-10-31 17:15 ` Russell King
2004-11-07 11:19 ` Russell King
0 siblings, 1 reply; 3+ messages in thread
From: Russell King @ 2004-10-31 17:15 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Linus Torvalds, Andrew Morton, Linux Kernel Development
On Sun, Oct 31, 2004 at 11:03:35AM +0100, Geert Uytterhoeven wrote:
> M68k serial: Only define SERIAL_PORT_DFNS when CONFIG_ISA is defined. Otherwise
> the first 4 slots in the 8250 driver are unavailable on non-ISA machines.
> (from Kars de Jong)
I won't be applying this patch - you may wish to consider doing this an
alternative way once the contents of my BK tree becomes public.
include/asm-*/serial.h is almost dead! Long live serial.h!
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 478] M68k SERIAL_PORT_DFNS only if CONFIG_ISA
2004-10-31 17:15 ` Russell King
@ 2004-11-07 11:19 ` Russell King
0 siblings, 0 replies; 3+ messages in thread
From: Russell King @ 2004-11-07 11:19 UTC (permalink / raw)
To: Geert Uytterhoeven, Linus Torvalds, Andrew Morton,
Linux Kernel Development
On Sun, Oct 31, 2004 at 05:15:44PM +0000, Russell King wrote:
> On Sun, Oct 31, 2004 at 11:03:35AM +0100, Geert Uytterhoeven wrote:
> > M68k serial: Only define SERIAL_PORT_DFNS when CONFIG_ISA is defined. Otherwise
> > the first 4 slots in the 8250 driver are unavailable on non-ISA machines.
> > (from Kars de Jong)
>
> I won't be applying this patch - you may wish to consider doing this an
> alternative way once the contents of my BK tree becomes public.
>
> include/asm-*/serial.h is almost dead! Long live serial.h!
Geert,
The changes are now in - please look again about defining SERIAL_PORT_DFNS
even for the CONFIG_ISA case.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-11-07 11:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-10-31 10:03 [PATCH 478] M68k SERIAL_PORT_DFNS only if CONFIG_ISA Geert Uytterhoeven
2004-10-31 17:15 ` Russell King
2004-11-07 11:19 ` Russell King
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.