From: Chuck Ebbert <76306.1226@compuserve.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH 504] m68k: smp_lock.h: Avoid recursive include
Date: Tue, 2 Nov 2004 02:46:35 -0500 [thread overview]
Message-ID: <200411020249_MC3-1-8DAD-7CF5@compuserve.com> (raw)
Linus Torvalds wrote:
>
> This one is _totally_ broken.
>
> Not only is that include not recursive, but it immediately breaks any SMP
> compile because that header file _needs_ the definition of "task_struct".
>
>
> On Sun, 31 Oct 2004, Geert Uytterhoeven wrote:
> >
> > smp_lock.h: Avoid recursive include
> >
> > --- linux-2.6.10-rc1/include/linux/smp_lock.h 2004-04-28 15:47:31.000000000 +0200
> > +++ linux-m68k-2.6.10-rc1/include/linux/smp_lock.h 2004-10-20 22:24:05.000000000 +0200
> > @@ -2,7 +2,6 @@
> > #define __LINUX_SMPLOCK_H
> >
> > #include <linux/config.h>
> > -#include <linux/sched.h>
Shouldn't you also revert cset 1.2405, also by Geert, which added
<linux/sched.h> to reiserfs_fs.h? Looks like that was done to fix
breakage caused by this change.
--Chuck Ebbert 02-Nov-04 03:48:03
next reply other threads:[~2004-11-02 7:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-02 7:46 Chuck Ebbert [this message]
2004-11-02 8:25 ` [PATCH 504] m68k: smp_lock.h: Avoid recursive include Geert Uytterhoeven
2004-11-02 21:28 ` Geert Uytterhoeven
-- strict thread matches above, loose matches on Subject: below --
2004-11-04 0:10 Chuck Ebbert
2004-10-31 10:03 [PATCH 504] " Geert Uytterhoeven
2004-11-01 0:13 ` [PATCH 504] m68k: " Linus Torvalds
2004-11-01 20:21 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200411020249_MC3-1-8DAD-7CF5@compuserve.com \
--to=76306.1226@compuserve.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.