* Re: [PATCH 504] m68k: smp_lock.h: Avoid recursive include
2004-10-31 10:03 [PATCH 504] " Geert Uytterhoeven
@ 2004-11-01 0:13 ` Linus Torvalds
2004-11-01 20:21 ` Geert Uytterhoeven
0 siblings, 1 reply; 6+ messages in thread
From: Linus Torvalds @ 2004-11-01 0:13 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Andrew Morton, Linux Kernel Development
This one is _totally_ broken.
Not only is that include not recursive, but it immediately breaks any SMP
compile because that header file _needs_ the definition of "task_struct".
I applied it without realizing it, but I'll undo it and I hope you fix
your broken tree so that I don't ever have to see this broken patch
again..
Linus
On Sun, 31 Oct 2004, Geert Uytterhoeven wrote:
>
> smp_lock.h: Avoid recursive include
>
> Signed-off-by: Roman Zippel <zippel@linux-m68k.org>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
>
> --- linux-2.6.10-rc1/include/linux/smp_lock.h 2004-04-28 15:47:31.000000000 +0200
> +++ linux-m68k-2.6.10-rc1/include/linux/smp_lock.h 2004-10-20 22:24:05.000000000 +0200
> @@ -2,7 +2,6 @@
> #define __LINUX_SMPLOCK_H
>
> #include <linux/config.h>
> -#include <linux/sched.h>
> #include <linux/spinlock.h>
>
> #if defined(CONFIG_SMP) || defined(CONFIG_PREEMPT)
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 504] m68k: smp_lock.h: Avoid recursive include
2004-11-01 0:13 ` [PATCH 504] m68k: " Linus Torvalds
@ 2004-11-01 20:21 ` Geert Uytterhoeven
0 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2004-11-01 20:21 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Andrew Morton, Roman Zippel, Linux Kernel Development
On Sun, 31 Oct 2004, Linus Torvalds wrote:
> Not only is that include not recursive, but it immediately breaks any SMP
It's not immediately recursive, but <linux/sched.h> includes about everything
and the kitchen sink, causing fatal problems on m68k since 2.6.9*...
> compile because that header file _needs_ the definition of "task_struct".
Sorry, forgot about SMP.
So we have to move the definition of "task_struct" to <linux/task_struct.h>
first, to avoid include hell. Cfr. what Roman Zippel is working on.
> I applied it without realizing it, but I'll undo it and I hope you fix
> your broken tree so that I don't ever have to see this broken patch
> again..
Don't worry, it has been moved to my POSTPONED queue :-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 504] m68k: smp_lock.h: Avoid recursive include
@ 2004-11-02 7:46 Chuck Ebbert
2004-11-02 8:25 ` Geert Uytterhoeven
0 siblings, 1 reply; 6+ messages in thread
From: Chuck Ebbert @ 2004-11-02 7:46 UTC (permalink / raw)
To: Linus Torvalds; +Cc: linux-kernel, Geert Uytterhoeven
Linus Torvalds wrote:
>
> This one is _totally_ broken.
>
> Not only is that include not recursive, but it immediately breaks any SMP
> compile because that header file _needs_ the definition of "task_struct".
>
>
> On Sun, 31 Oct 2004, Geert Uytterhoeven wrote:
> >
> > smp_lock.h: Avoid recursive include
> >
> > --- linux-2.6.10-rc1/include/linux/smp_lock.h 2004-04-28 15:47:31.000000000 +0200
> > +++ linux-m68k-2.6.10-rc1/include/linux/smp_lock.h 2004-10-20 22:24:05.000000000 +0200
> > @@ -2,7 +2,6 @@
> > #define __LINUX_SMPLOCK_H
> >
> > #include <linux/config.h>
> > -#include <linux/sched.h>
Shouldn't you also revert cset 1.2405, also by Geert, which added
<linux/sched.h> to reiserfs_fs.h? Looks like that was done to fix
breakage caused by this change.
--Chuck Ebbert 02-Nov-04 03:48:03
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 504] m68k: smp_lock.h: Avoid recursive include
2004-11-02 7:46 [PATCH 504] m68k: smp_lock.h: Avoid recursive include Chuck Ebbert
@ 2004-11-02 8:25 ` Geert Uytterhoeven
2004-11-02 21:28 ` Geert Uytterhoeven
0 siblings, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2004-11-02 8:25 UTC (permalink / raw)
To: Chuck Ebbert; +Cc: Linus Torvalds, linux-kernel
On Tue, 2 Nov 2004, Chuck Ebbert wrote:
> Linus Torvalds wrote:
> > This one is _totally_ broken.
> >
> > Not only is that include not recursive, but it immediately breaks any SMP
> > compile because that header file _needs_ the definition of "task_struct".
> >
> > On Sun, 31 Oct 2004, Geert Uytterhoeven wrote:
> > > smp_lock.h: Avoid recursive include
> > >
> > > --- linux-2.6.10-rc1/include/linux/smp_lock.h 2004-04-28 15:47:31.000000000 +0200
> > > +++ linux-m68k-2.6.10-rc1/include/linux/smp_lock.h 2004-10-20 22:24:05.000000000 +0200
> > > @@ -2,7 +2,6 @@
> > > #define __LINUX_SMPLOCK_H
> > >
> > > #include <linux/config.h>
> > > -#include <linux/sched.h>
>
>
> Shouldn't you also revert cset 1.2405, also by Geert, which added
> <linux/sched.h> to reiserfs_fs.h? Looks like that was done to fix
> breakage caused by this change.
You can discuss about that: reiserfs_fs.h used current including sched.h.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 504] m68k: smp_lock.h: Avoid recursive include
2004-11-02 8:25 ` Geert Uytterhoeven
@ 2004-11-02 21:28 ` Geert Uytterhoeven
0 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2004-11-02 21:28 UTC (permalink / raw)
To: Chuck Ebbert; +Cc: Linus Torvalds, linux-kernel
On Tue, 2 Nov 2004, Geert Uytterhoeven wrote:
> On Tue, 2 Nov 2004, Chuck Ebbert wrote:
> > Linus Torvalds wrote:
> > > This one is _totally_ broken.
> > >
> > > Not only is that include not recursive, but it immediately breaks any SMP
> > > compile because that header file _needs_ the definition of "task_struct".
> > >
> > > On Sun, 31 Oct 2004, Geert Uytterhoeven wrote:
> > > > smp_lock.h: Avoid recursive include
> > > >
> > > > --- linux-2.6.10-rc1/include/linux/smp_lock.h 2004-04-28 15:47:31.000000000 +0200
> > > > +++ linux-m68k-2.6.10-rc1/include/linux/smp_lock.h 2004-10-20 22:24:05.000000000 +0200
> > > > @@ -2,7 +2,6 @@
> > > > #define __LINUX_SMPLOCK_H
> > > >
> > > > #include <linux/config.h>
> > > > -#include <linux/sched.h>
> >
> >
> > Shouldn't you also revert cset 1.2405, also by Geert, which added
> > <linux/sched.h> to reiserfs_fs.h? Looks like that was done to fix
> > breakage caused by this change.
>
> You can discuss about that: reiserfs_fs.h used current including sched.h.
^
Oops, there's a missing `without' here...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 504] m68k: smp_lock.h: Avoid recursive include
@ 2004-11-04 0:10 Chuck Ebbert
0 siblings, 0 replies; 6+ messages in thread
From: Chuck Ebbert @ 2004-11-04 0:10 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: linux-kernel, Linus Torvalds, Hans Reiser
On Tue, 2 Nov 2004 at 22:28:36 +0100 Geert Uytterhoeven wrote:
> > You can discuss about that: reiserfs_fs.h used current including sched.h.
> ^
> Oops, there's a missing `without' here...
Yes, but reiserfs_fs.h includes smp_lock.h, and that included sched.h until
you removed it. Now that sched.h is back in smp_lock.h, its inclusion directly
in reiserfs_fs.h should be unnecessary...
--Chuck Ebbert 03-Nov-04 20:06:17
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2004-11-04 0:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-11-02 7:46 [PATCH 504] m68k: smp_lock.h: Avoid recursive include Chuck Ebbert
2004-11-02 8:25 ` Geert Uytterhoeven
2004-11-02 21:28 ` Geert Uytterhoeven
-- strict thread matches above, loose matches on Subject: below --
2004-11-04 0:10 Chuck Ebbert
2004-10-31 10:03 [PATCH 504] " Geert Uytterhoeven
2004-11-01 0:13 ` [PATCH 504] m68k: " Linus Torvalds
2004-11-01 20:21 ` Geert Uytterhoeven
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.