All of lore.kernel.org
 help / color / mirror / Atom feed
From: Grant Grundler <grundler@parisc-linux.org>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Grant Grundler <grundler@parisc-linux.org>,
	matthew@wil.cx, linux-ide@vger.kernel.org
Subject: Re: [PATCH] PA-RISC update to 87415
Date: Wed, 3 Nov 2004 16:23:56 -0700	[thread overview]
Message-ID: <20041103232356.GD23415@colo.lackof.org> (raw)
In-Reply-To: <58cb370e041103140121017ea1@mail.gmail.com>

On Wed, Nov 03, 2004 at 11:01:58PM +0100, Bartlomiej Zolnierkiewicz wrote:
> > 1) both comments are wrong.
> >   (byte write only covers LATENCY, pci_set_master is called)
> 
> ?

	/* Set a good latency timer and cache line size value. */

The PCI config write only modifies the latency timer, not the cache line
size register.

#define PCI_CACHE_LINE_SIZE     0x0c    /* 8 bits */
#define PCI_LATENCY_TIMER       0x0d    /* 8 bits */

	/* FIXME: use pci_set_master() to ensure good latency timer value */

This has been in fact already been fixed.
That's why I submitted the patch to delete the code.

thanks,
grant

  parent reply	other threads:[~2004-11-03 23:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-03 20:00 [PATCH] PA-RISC update to 87415 Grant Grundler
2004-11-03 20:21 ` Bartlomiej Zolnierkiewicz
2004-11-03 21:19   ` Grant Grundler
2004-11-03 21:33   ` Grant Grundler
2004-11-03 22:01     ` Bartlomiej Zolnierkiewicz
2004-11-03 23:19       ` Grant Grundler
2004-11-03 23:23       ` Grant Grundler [this message]
2004-11-05 20:17         ` Bartlomiej Zolnierkiewicz
2004-11-06  6:28           ` Grant Grundler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041103232356.GD23415@colo.lackof.org \
    --to=grundler@parisc-linux.org \
    --cc=bzolnier@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=matthew@wil.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.