Re: [PATCH] PA-RISC update to 87415

[Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>]

On Wed, 3 Nov 2004 14:33:51 -0700, Grant Grundler
<grundler@parisc-linux.org> wrote:
> 
> 
> On Wed, Nov 03, 2004 at 09:21:02PM +0100, Bartlomiej Zolnierkiewicz wrote:
> > I only wonder about this change:
> >
> > > @@ -132,10 +212,6 @@ static void __init init_hwif_ns87415 (id
> > >         hwif->autodma = 0;
> > >         hwif->selectproc = &ns87415_selectproc;
> > >
> > > -       /* Set a good latency timer and cache line size value. */
> > > -       (void) pci_write_config_byte(dev, PCI_LATENCY_TIMER, 64);
> > > -       /* FIXME: use pci_set_master() to ensure good latency timer value */
> 
> Bartlomiej,
> two more notes:
> 1) both comments are wrong.
>   (byte write only covers LATENCY, pci_set_master is called)

?

> 2) I realize now this should have been submitted this as a seperate patch.
>    Sorry about that. I didn't review the patch today (again) as thoroughly
>    as I should have. I started glossing over it when I saw all the suckyio
>    code that I've stared at more than a few times...*sigh*
>    You want a seperate patch+changelog entry for this one or was the
>    previous email sufficient?

Please make a separate patch+changelog if this is not a problem.

Thanks.