From: Matt Domsch <Matt_Domsch@dell.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
hadi@cyberus.ca, netdev@oss.sgi.com
Subject: Re: [PATCH 2.6] dev.c: clear SIOCGIFHWADDR buffer if !dev->addr_len
Date: Wed, 3 Nov 2004 21:42:42 -0600 [thread overview]
Message-ID: <20041104034241.GA26300@lists.us.dell.com> (raw)
In-Reply-To: <20041103160727.54dc0c15.davem@davemloft.net>
On Wed, Nov 03, 2004 at 04:07:27PM -0800, David S. Miller wrote:
> On Tue, 2 Nov 2004 09:06:44 +1100
> Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> > On Mon, Nov 01, 2004 at 03:59:44PM -0600, Matt Domsch wrote:
> > >
> > > Actually, -EOVERFLOW appears throughout the kernel. A couple examples:
> >
> > I agree. Please disregard my comment re ERANGE.
>
> I think there is nothing wrong with clearing out the buffer
> for the !dev->addr_len case. This is not to say that what
> the apps are doing is correct or not, it merely preserves
> 2.4.x behavior which was changed unintentionally.
>
> I'm going to apply Matt's patch which began this thread.
If it's all the same to you, I prefer the last version. If you want
to remove the net_ratelimited printk, that would be fine too. Either
way the apps will work as expected again.
Thanks,
Matt
--
Matt Domsch
Sr. Software Engineer, Lead Engineer
Dell Linux Solutions linux.dell.com & www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com
next prev parent reply other threads:[~2004-11-04 3:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-29 21:51 [PATCH 2.6] dev.c: clear SIOCGIFHWADDR buffer if !dev->addr_len Matt Domsch
2004-10-30 1:37 ` Matt Domsch
2004-10-30 1:51 ` Herbert Xu
2004-10-30 3:09 ` Matt Domsch
2004-10-30 19:10 ` jamal
2004-11-01 4:44 ` Matt Domsch
2004-11-01 17:34 ` Matt Domsch
2004-11-01 20:27 ` Herbert Xu
2004-11-01 20:38 ` Matt Domsch
2004-11-01 20:41 ` Herbert Xu
2004-11-01 20:45 ` Matt Domsch
2004-11-01 21:50 ` jamal
2004-11-01 21:59 ` Matt Domsch
2004-11-01 22:06 ` Herbert Xu
2004-11-04 0:07 ` David S. Miller
2004-11-04 3:42 ` Matt Domsch [this message]
2004-11-01 22:03 ` Herbert Xu
2004-10-30 1:48 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041104034241.GA26300@lists.us.dell.com \
--to=matt_domsch@dell.com \
--cc=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.