* Re: 2.6.10-rc1-mm3
[not found] ` <418B5C70.7090206@kolivas.org.suse.lists.linux.kernel>
@ 2004-11-05 11:53 ` Andi Kleen
2004-11-05 12:16 ` 2.6.10-rc1-mm3 Con Kolivas
0 siblings, 1 reply; 6+ messages in thread
From: Andi Kleen @ 2004-11-05 11:53 UTC (permalink / raw)
To: Con Kolivas; +Cc: linux-kernel
Con Kolivas <kernel@kolivas.org> writes:
> It's life Jim but not as we know it...
>
>
> This happened during modprobe of alsa modules. Keyboard still alive,
> everything else dead; not even sysrq would do anything, netconsole had
> no output, luckily this made it to syslog:
I just tested modprobing of alsa (snd_intel8x0) and it works for me.
Also vmalloc must work at least to some point.
Can you confirm it's really caused by 4level by reverting all the
4level-* patches from broken out?
-Andi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: 2.6.10-rc1-mm3
2004-11-05 11:53 ` 2.6.10-rc1-mm3 Andi Kleen
@ 2004-11-05 12:16 ` Con Kolivas
2004-11-05 12:23 ` 2.6.10-rc1-mm3 Andi Kleen
2004-11-05 13:12 ` [PATCH] Fix for vmalloc problem was 2.6.10-rc1-mm3 Andi Kleen
0 siblings, 2 replies; 6+ messages in thread
From: Con Kolivas @ 2004-11-05 12:16 UTC (permalink / raw)
To: Andi Kleen; +Cc: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 612 bytes --]
Andi Kleen wrote:
> Con Kolivas <kernel@kolivas.org> writes:
>
>
>>It's life Jim but not as we know it...
>>
>>
>>This happened during modprobe of alsa modules. Keyboard still alive,
>>everything else dead; not even sysrq would do anything, netconsole had
>>no output, luckily this made it to syslog:
>
>
> I just tested modprobing of alsa (snd_intel8x0) and it works for me.
> Also vmalloc must work at least to some point.
>
> Can you confirm it's really caused by 4level by reverting all the
> 4level-* patches from broken out?
I dont recall blaming 4level. When I get a chance I'll try.
Cheers,
Con
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 256 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: 2.6.10-rc1-mm3
2004-11-05 12:16 ` 2.6.10-rc1-mm3 Con Kolivas
@ 2004-11-05 12:23 ` Andi Kleen
2004-11-05 13:12 ` [PATCH] Fix for vmalloc problem was 2.6.10-rc1-mm3 Andi Kleen
1 sibling, 0 replies; 6+ messages in thread
From: Andi Kleen @ 2004-11-05 12:23 UTC (permalink / raw)
To: Con Kolivas; +Cc: Andi Kleen, linux-kernel
On Fri, Nov 05, 2004 at 11:16:24PM +1100, Con Kolivas wrote:
> Andi Kleen wrote:
> >Con Kolivas <kernel@kolivas.org> writes:
> >
> >
> >>It's life Jim but not as we know it...
> >>
> >>
> >>This happened during modprobe of alsa modules. Keyboard still alive,
> >>everything else dead; not even sysrq would do anything, netconsole had
> >>no output, luckily this made it to syslog:
> >
> >
> >I just tested modprobing of alsa (snd_intel8x0) and it works for me.
> >Also vmalloc must work at least to some point.
> >
> >Can you confirm it's really caused by 4level by reverting all the
> >4level-* patches from broken out?
>
> I dont recall blaming 4level. When I get a chance I'll try.
I can reproduce it now using a forced big vmalloc. It's probably
4level. Debugging...
-Andi
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] Fix for vmalloc problem was Re: 2.6.10-rc1-mm3
2004-11-05 12:16 ` 2.6.10-rc1-mm3 Con Kolivas
2004-11-05 12:23 ` 2.6.10-rc1-mm3 Andi Kleen
@ 2004-11-05 13:12 ` Andi Kleen
2004-11-05 13:29 ` Con Kolivas
1 sibling, 1 reply; 6+ messages in thread
From: Andi Kleen @ 2004-11-05 13:12 UTC (permalink / raw)
To: Con Kolivas; +Cc: Andi Kleen, linux-kernel, akpm
On Fri, Nov 05, 2004 at 11:16:24PM +1100, Con Kolivas wrote:
> Andi Kleen wrote:
> >Con Kolivas <kernel@kolivas.org> writes:
> >
> >
> >>It's life Jim but not as we know it...
> >>
> >>
> >>This happened during modprobe of alsa modules. Keyboard still alive,
> >>everything else dead; not even sysrq would do anything, netconsole had
> >>no output, luckily this made it to syslog:
> >
> >
> >I just tested modprobing of alsa (snd_intel8x0) and it works for me.
> >Also vmalloc must work at least to some point.
> >
> >Can you confirm it's really caused by 4level by reverting all the
> >4level-* patches from broken out?
>
> I dont recall blaming 4level. When I get a chance I'll try.
This patch should fix it. Can you please test? Thanks.
-Andi
Fix silly typo in mm/vmalloc.c and some minor cleanups.
Signed-off-by: Andi Kleen <ak@suse.de>
diff -up linux-2.6.10rc1-mm3/mm/vmalloc.c-o linux-2.6.10rc1-mm3/mm/vmalloc.c
--- linux-2.6.10rc1-mm3/mm/vmalloc.c-o 2004-11-05 11:42:00.000000000 +0100
+++ linux-2.6.10rc1-mm3/mm/vmalloc.c 2004-11-05 14:10:04.000000000 +0100
@@ -98,7 +98,6 @@ static void unmap_area_pgd(pml4_t *pml4,
}
pgd = pml4_pgd_offset_k(pml4, address);
- address &= ~PML4_MASK;
end = address + size;
do {
@@ -114,8 +113,8 @@ static int map_area_pte(pte_t *pte, unsi
{
unsigned long end;
- address &= ~PMD_MASK;
end = address + size;
+ address &= ~PMD_MASK;
if (end > PMD_SIZE)
end = PMD_SIZE;
@@ -187,7 +186,7 @@ void unmap_vm_area(struct vm_struct *are
flush_cache_vunmap(address, end);
for (i = pml4_index(address); i <= pml4_index(end-1); i++) {
next = (address + PML4_SIZE) & PML4_MASK;
- if (next <= address || next > end)
+ if (next < address || next > end)
next = end;
unmap_area_pgd(pml4, address, next - address);
address = next;
@@ -213,7 +212,7 @@ int map_vm_area(struct vm_struct *area,
err = -ENOMEM;
break;
}
- next = (address + PGDIR_SIZE) & PGDIR_MASK;
+ next = (address + PML4_SIZE) & PML4_MASK;
if (next < address || next > end)
next = end;
if (map_area_pgd(pgd, address, next, prot, pages)) {
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix for vmalloc problem was Re: 2.6.10-rc1-mm3
2004-11-05 13:12 ` [PATCH] Fix for vmalloc problem was 2.6.10-rc1-mm3 Andi Kleen
@ 2004-11-05 13:29 ` Con Kolivas
2004-11-05 13:53 ` Andi Kleen
0 siblings, 1 reply; 6+ messages in thread
From: Con Kolivas @ 2004-11-05 13:29 UTC (permalink / raw)
To: Andi Kleen; +Cc: linux-kernel, akpm
[-- Attachment #1: Type: text/plain, Size: 882 bytes --]
Andi Kleen wrote:
> On Fri, Nov 05, 2004 at 11:16:24PM +1100, Con Kolivas wrote:
>
>>Andi Kleen wrote:
>>
>>>Con Kolivas <kernel@kolivas.org> writes:
>>>
>>>
>>>
>>>>It's life Jim but not as we know it...
>>>>
>>>>
>>>>This happened during modprobe of alsa modules. Keyboard still alive,
>>>>everything else dead; not even sysrq would do anything, netconsole had
>>>>no output, luckily this made it to syslog:
>>>
>>>
>>>I just tested modprobing of alsa (snd_intel8x0) and it works for me.
>>>Also vmalloc must work at least to some point.
>>>
>>>Can you confirm it's really caused by 4level by reverting all the
>>>4level-* patches from broken out?
>>
>>I dont recall blaming 4level. When I get a chance I'll try.
>
>
> This patch should fix it. Can you please test? Thanks.
>
> -Andi
>
> Fix silly typo in mm/vmalloc.c and some minor cleanups.
Boots fine now thanks.
Con
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 256 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix for vmalloc problem was Re: 2.6.10-rc1-mm3
2004-11-05 13:29 ` Con Kolivas
@ 2004-11-05 13:53 ` Andi Kleen
0 siblings, 0 replies; 6+ messages in thread
From: Andi Kleen @ 2004-11-05 13:53 UTC (permalink / raw)
To: Con Kolivas; +Cc: Andi Kleen, linux-kernel, akpm
On Sat, Nov 06, 2004 at 12:29:43AM +1100, Con Kolivas wrote:
> Andi Kleen wrote:
> >On Fri, Nov 05, 2004 at 11:16:24PM +1100, Con Kolivas wrote:
> >
> >>Andi Kleen wrote:
> >>
> >>>Con Kolivas <kernel@kolivas.org> writes:
> >>>
> >>>
> >>>
> >>>>It's life Jim but not as we know it...
> >>>>
> >>>>
> >>>>This happened during modprobe of alsa modules. Keyboard still alive,
> >>>>everything else dead; not even sysrq would do anything, netconsole had
> >>>>no output, luckily this made it to syslog:
> >>>
> >>>
> >>>I just tested modprobing of alsa (snd_intel8x0) and it works for me.
> >>>Also vmalloc must work at least to some point.
> >>>
> >>>Can you confirm it's really caused by 4level by reverting all the
> >>>4level-* patches from broken out?
> >>
> >>I dont recall blaming 4level. When I get a chance I'll try.
> >
> >
> >This patch should fix it. Can you please test? Thanks.
> >
> >-Andi
> >
> >Fix silly typo in mm/vmalloc.c and some minor cleanups.
>
> Boots fine now thanks.
It broke x86-64 unfortunately. This version should be better and is
simpler. Andrew, if you applied the previous version please replace
with this one.
-Andi
Fix vmalloc overflow with 4levels.
Signed-off-by: Andi Kleen <ak@suse.de>
diff -up linux-2.6.10rc1-mm3/mm/vmalloc.c-o linux-2.6.10rc1-mm3/mm/vmalloc.c
--- linux-2.6.10rc1-mm3/mm/vmalloc.c-o 2004-11-05 11:42:00.000000000 +0100
+++ linux-2.6.10rc1-mm3/mm/vmalloc.c 2004-11-05 14:49:25.000000000 +0100
@@ -213,7 +213,7 @@ int map_vm_area(struct vm_struct *area,
err = -ENOMEM;
break;
}
- next = (address + PGDIR_SIZE) & PGDIR_MASK;
+ next = (address + PML4_SIZE) & PML4_MASK;
if (next < address || next > end)
next = end;
if (map_area_pgd(pgd, address, next, prot, pages)) {
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2004-11-05 13:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20041105001328.3ba97e08.akpm@osdl.org.suse.lists.linux.kernel>
[not found] ` <418B5C70.7090206@kolivas.org.suse.lists.linux.kernel>
2004-11-05 11:53 ` 2.6.10-rc1-mm3 Andi Kleen
2004-11-05 12:16 ` 2.6.10-rc1-mm3 Con Kolivas
2004-11-05 12:23 ` 2.6.10-rc1-mm3 Andi Kleen
2004-11-05 13:12 ` [PATCH] Fix for vmalloc problem was 2.6.10-rc1-mm3 Andi Kleen
2004-11-05 13:29 ` Con Kolivas
2004-11-05 13:53 ` Andi Kleen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.