All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
Cc: Len Brown <len.brown@intel.com>,
	ACPI Developers <acpi-devel@lists.sourceforge.net>,
	linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] drivers/acpi: remove unused exported functions
Date: Sat, 6 Nov 2004 22:29:17 +0100	[thread overview]
Message-ID: <20041106212917.GP1295@stusta.de> (raw)
In-Reply-To: <418CEE3A.40503@conectiva.com.br>

On Sat, Nov 06, 2004 at 01:31:06PM -0200, Arnaldo Carvalho de Melo wrote:
> 
> Suggestion that satisfies both of you, I think:
> 
> #undef ACPI_FUTURE_USAGE
> #ifdef ACPI_FUTURE_USAGE
> tons of unused exported functions
> #endif /* ACPU_FUTURE_USAGE */
> 
> This is what is being done in at least one case in the kernel network
> subsystem, incremental patches adds new functions, to be used by
> future patches, but sometimes Real Life (tm) gets in the way and the
> programmer stalls development for some time, no problem, just ifdef it.
> 
> When, in the future, some functions start being used, hey, very easy
> to remove the #ifdef.
> 
> Even for people trying to debug such subsystems eventually to get
> something working its _nice_ to know at first glance what is really
> being used, speeding up the process for the benefit or everybody.

That's a good idea.

To make it easier, I could send a patc to move all the ACPI 
EXPORT_SYMBOL's away from acpi_ksyms.c or you have to touch two files 
for every function.

@Len:
What's your opinion on this proposal?

> Best Regards,
> 
> - Arnaldo
>...

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

  reply	other threads:[~2004-11-06 21:29 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-05 21:50 [2.6 patch] drivers/acpi: remove unused exported functions Adrian Bunk
2004-11-06  2:10 ` Len Brown
2004-11-06 11:48   ` Adrian Bunk
2004-11-06 15:31     ` Arnaldo Carvalho de Melo
2004-11-06 21:29       ` Adrian Bunk [this message]
2004-11-06 21:21         ` Arnaldo Carvalho de Melo
     [not found]           ` <418D403E.30608-KCZ47A4bww4P48s/oLjRZg@public.gmane.org>
2004-11-08 17:01             ` Len Brown
2004-11-08 17:01               ` Len Brown
2004-11-09  1:40               ` [2.6 patch] kill acpi_ksyms.c Adrian Bunk
     [not found]                 ` <20041109014021.GB15077-HeJ8Db2Gnd6zQB+pC5nmwQ@public.gmane.org>
2004-11-12  4:56                   ` Len Brown
2004-11-12  4:56                     ` Len Brown
2004-11-10  1:21               ` [2.6 patch] drivers/acpi: #ifdef unused functions away Adrian Bunk
2004-11-10  1:21                 ` Adrian Bunk
     [not found]                 ` <20041110012134.GB4089-HeJ8Db2Gnd6zQB+pC5nmwQ@public.gmane.org>
2004-11-11 15:17                   ` Matthew Wilcox
2004-11-11 15:17                     ` [ACPI] " Matthew Wilcox
     [not found]                     ` <20041111151727.GB1108-+pPCBgu9SkPzIGdyhVEDUDl5KyyQGfY2kSSpQ9I8OhVaa/9Udqfwiw@public.gmane.org>
2004-11-11 15:36                       ` Adrian Bunk
2004-11-11 15:36                         ` [ACPI] " Adrian Bunk
     [not found]                         ` <20041111153650.GD8417-HeJ8Db2Gnd6zQB+pC5nmwQ@public.gmane.org>
2004-11-11 15:40                           ` Matthew Wilcox
2004-11-11 15:40                             ` [ACPI] " Matthew Wilcox
     [not found]                             ` <20041111154017.GC1108-+pPCBgu9SkPzIGdyhVEDUDl5KyyQGfY2kSSpQ9I8OhVaa/9Udqfwiw@public.gmane.org>
2004-11-11 15:46                               ` Adrian Bunk
2004-11-11 15:46                                 ` [ACPI] " Adrian Bunk
     [not found]                                 ` <20041111154656.GE8417-HeJ8Db2Gnd6zQB+pC5nmwQ@public.gmane.org>
2004-11-11 16:08                                   ` Matthew Wilcox
2004-11-11 16:08                                     ` [ACPI] " Matthew Wilcox
     [not found]                                     ` <20041111160842.GD1108-+pPCBgu9SkPzIGdyhVEDUDl5KyyQGfY2kSSpQ9I8OhVaa/9Udqfwiw@public.gmane.org>
2004-11-11 19:17                                       ` Len Brown
2004-11-11 19:17                                         ` [ACPI] " Len Brown
2004-11-10 23:38   ` [2.6 patch] drivers/acpi: remove unused exported functions Pavel Machek
2004-11-10 23:38     ` Pavel Machek
2004-11-06 20:39 ` [ACPI] " Matthew Wilcox
2004-11-06 21:26   ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041106212917.GP1295@stusta.de \
    --to=bunk@stusta.de \
    --cc=acme@conectiva.com.br \
    --cc=acpi-devel@lists.sourceforge.net \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.