* [PATCH] Function / prototype mismatch
@ 2004-11-09 12:28 Thomas Koeller
2004-11-09 12:45 ` Christoph Hellwig
2004-11-09 12:56 ` Ralf Baechle
0 siblings, 2 replies; 6+ messages in thread
From: Thomas Koeller @ 2004-11-09 12:28 UTC (permalink / raw)
To: linux-mips
The definition of do_IRQ() in arch/mips/kernel/irq.c
does not match the prototype in include/asm-mips/irq.h,
resulting in a compile error.
tk
Signed-off-by: Thomas Koeller <thomas.koeller@baslerweb.com>
--- linux-mips-cvs/arch/mips/kernel/irq.c 2004-11-09 11:43:46.921669824 +0100
+++ linux-mips-basler/arch/mips/kernel/irq.c 2004-11-09 13:18:46.496202792 +0100
@@ -45,7 +45,7 @@
* SMP cross-CPU interrupts have their own specific
* handlers).
*/
-asmlinkage unsigned int do_IRQ(unsigned int irq, struct pt_regs *regs)
+asmlinkage unsigned int do_IRQ(int irq, struct pt_regs *regs)
{
irq_enter();
--
--------------------------------------------------
Thomas Koeller, Software Development
Basler Vision Technologies
thomas dot koeller at baslerweb dot com
http://www.baslerweb.com
==============================
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Function / prototype mismatch
2004-11-09 12:28 [PATCH] Function / prototype mismatch Thomas Koeller
@ 2004-11-09 12:45 ` Christoph Hellwig
2004-11-09 12:54 ` Ralf Baechle
2004-11-09 12:56 ` Ralf Baechle
1 sibling, 1 reply; 6+ messages in thread
From: Christoph Hellwig @ 2004-11-09 12:45 UTC (permalink / raw)
To: Thomas Koeller; +Cc: linux-mips
On Tue, Nov 09, 2004 at 01:28:42PM +0100, Thomas Koeller wrote:
> The definition of do_IRQ() in arch/mips/kernel/irq.c
> does not match the prototype in include/asm-mips/irq.h,
> resulting in a compile error.
<hint>
might be worse to switch mips to the generic kernel/irq/ code
whicg gets this right
</hint>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Function / prototype mismatch
2004-11-09 12:45 ` Christoph Hellwig
@ 2004-11-09 12:54 ` Ralf Baechle
2004-11-09 12:59 ` Christoph Hellwig
0 siblings, 1 reply; 6+ messages in thread
From: Ralf Baechle @ 2004-11-09 12:54 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Thomas Koeller, linux-mips
On Tue, Nov 09, 2004 at 01:45:47PM +0100, Christoph Hellwig wrote:
> <hint>
> might be worse to switch mips to the generic kernel/irq/ code
> whicg gets this right
> </hint>
<hint>
This has long happened and generic irq code doesn't even cover do_IRQ.
</hint>
Ralf
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Function / prototype mismatch
2004-11-09 12:28 [PATCH] Function / prototype mismatch Thomas Koeller
2004-11-09 12:45 ` Christoph Hellwig
@ 2004-11-09 12:56 ` Ralf Baechle
1 sibling, 0 replies; 6+ messages in thread
From: Ralf Baechle @ 2004-11-09 12:56 UTC (permalink / raw)
To: Thomas Koeller; +Cc: linux-mips
On Tue, Nov 09, 2004 at 01:28:42PM +0100, Thomas Koeller wrote:
> The definition of do_IRQ() in arch/mips/kernel/irq.c
> does not match the prototype in include/asm-mips/irq.h,
> resulting in a compile error.
[ralf@fluff linux]$ grep -r do_IRQ include/linux
include/linux/irq.h:extern asmlinkage unsigned int __do_IRQ(unsigned int irq, struct pt_regs *regs);
[ralf@fluff linux]$
Just reposting somebody else's broken fix doesn't increase chances that I
take a patch ...
Ralf
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Function / prototype mismatch
2004-11-09 12:54 ` Ralf Baechle
@ 2004-11-09 12:59 ` Christoph Hellwig
2004-11-09 13:25 ` Ralf Baechle
0 siblings, 1 reply; 6+ messages in thread
From: Christoph Hellwig @ 2004-11-09 12:59 UTC (permalink / raw)
To: Ralf Baechle; +Cc: Christoph Hellwig, Thomas Koeller, linux-mips
On Tue, Nov 09, 2004 at 01:54:18PM +0100, Ralf Baechle wrote:
> On Tue, Nov 09, 2004 at 01:45:47PM +0100, Christoph Hellwig wrote:
>
> > <hint>
> > might be worse to switch mips to the generic kernel/irq/ code
> > whicg gets this right
> > </hint>
>
> <hint>
> This has long happened and generic irq code doesn't even cover do_IRQ.
Well, 90% of it as __do_IRQ ;-)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Function / prototype mismatch
2004-11-09 12:59 ` Christoph Hellwig
@ 2004-11-09 13:25 ` Ralf Baechle
0 siblings, 0 replies; 6+ messages in thread
From: Ralf Baechle @ 2004-11-09 13:25 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Thomas Koeller, linux-mips
On Tue, Nov 09, 2004 at 01:59:12PM +0100, Christoph Hellwig wrote:
> Well, 90% of it as __do_IRQ ;-)
Would seem natural to have the same prototype for both, wouldn't it?
Ralf
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2004-11-09 13:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-11-09 12:28 [PATCH] Function / prototype mismatch Thomas Koeller
2004-11-09 12:45 ` Christoph Hellwig
2004-11-09 12:54 ` Ralf Baechle
2004-11-09 12:59 ` Christoph Hellwig
2004-11-09 13:25 ` Ralf Baechle
2004-11-09 12:56 ` Ralf Baechle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.