Re: [KJ] [PATCH] convert airo wireless driver to module_param

From: Stefan Sperling <stefan@binarchy.net>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] convert airo wireless driver to module_param
Date: Tue, 09 Nov 2004 22:21:06 +0000	[thread overview]
Message-ID: <20041109222106.GA10645@dice.seeling33.de> (raw)
In-Reply-To: <20041109212957.GA9496@dice.seeling33.de>

[-- Attachment #1: Type: text/plain, Size: 838 bytes --]

On Tue, Nov 09, 2004 at 01:38:18PM -0800, Randy.Dunlap wrote:
> Stefan Sperling wrote:

> Rusty's first set of module_param() conversion patches, which
> I mostly followed, use permission (last parameter) of 0
> (not visible in sysfs) except for fields that can be modified.
> Often this is a "debug" or "verbose" flag or bitmask.

Not in this one:

http://marc.theaimsgroup.com/?l=linux-kernel&m=109826168201622&w=2

This is the reference link from the janitors TODO file.
Everything 0444, except a debug flag, which is 0644.

Can someone please clarify the "official guidelines" for
module parameter permissions in sysfs? Shall I use 0 or 0444
for parameters that should not be modified, i.e. everything
except debug and verbosity flags?

thanks
stefan
-- 
Give me a fish and I will eat today.
Teach me to fish and I will eat forever.

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors