From: "Randy.Dunlap" <rddunlap@osdl.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] convert airo wireless driver to module_param
Date: Tue, 09 Nov 2004 22:29:07 +0000 [thread overview]
Message-ID: <419144B3.4090303@osdl.org> (raw)
In-Reply-To: <20041109212957.GA9496@dice.seeling33.de>
Stefan Sperling wrote:
> On Tue, Nov 09, 2004 at 01:38:18PM -0800, Randy.Dunlap wrote:
>
>>Why make these writable, even by root?
>>Why make them visible?
>>
>>Rusty's first set of module_param() conversion patches, which
>>I mostly followed, use permission (last parameter) of 0
>>(not visible in sysfs) except for fields that can be modified.
>>Often this is a "debug" or "verbose" flag or bitmask.
>>
>>Many of these shouldn't be exposed in sysfs IMO.
>
>
> OK, I wasn't too sure about permissions anyway.
> I thought the general idea was to allow autoconfiguration through sysfs,
> and expose a driver's internal state to diagnostic tools in user space.
> So I only 0444'd parameters that should obviously not be changed at runtime,
> such as IO ports and IRQs.
>
> I'll try again and make everything invisible except debug/verbosity flags.
> Since you mentioned bitmasks, is it safe to make irq bitmasks writable as well?
> I made them read-only.
I mentioned bitmasks because some debug variables aren't boolean,
they are bit flags, or sometimes they are an integer (debug level).
No, I don't think that irq bitmasks should be writeable.
Having any system reource data writeable (like IRQ) is asking for
trouble IMO.
--
~Randy
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2004-11-09 22:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-09 21:29 [KJ] [PATCH] convert airo wireless driver to module_param Stefan Sperling
2004-11-09 21:38 ` Randy.Dunlap
2004-11-09 22:05 ` Stefan Sperling
2004-11-09 22:21 ` Stefan Sperling
2004-11-09 22:28 ` Randy.Dunlap
2004-11-09 22:29 ` Greg KH
2004-11-09 22:29 ` Randy.Dunlap [this message]
2004-11-09 22:56 ` Stefan Sperling
2004-11-09 22:58 ` Stefan Sperling
2004-11-09 23:16 ` Stefan Sperling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=419144B3.4090303@osdl.org \
--to=rddunlap@osdl.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.