From: Greg KH <greg@kroah.com>
To: Keshavamurthy Anil S <anil.s.keshavamurthy@intel.com>
Cc: Hotplug List <linux-hotplug-devel@lists.sourceforge.net>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kobject: fix double kobject_put in kobject_unregister()
Date: Wed, 10 Nov 2004 22:54:21 +0000 [thread overview]
Message-ID: <20041110225421.GA16785@kroah.com> (raw)
In-Reply-To: <20041110141923.A13668@unix-os.sc.intel.com>
On Wed, Nov 10, 2004 at 02:19:23PM -0800, Keshavamurthy Anil S wrote:
> Hi Greg,
>
> This patch fixes the problem where in kobject resources were getting
> freed when those kobject were still in use due to double kobject_put()
> getting called in the kobject_unregister() code path.
>
> With out this patch kobject_unregister() will have some serious side effects.
>
> Please apply.
>
> signed-off-by: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>
>
>
> linux-2.6.10-rc1-mm4-askeshav/lib/kobject.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletion(-)
>
> diff -puN lib/kobject.c~kobject_unregister_fix lib/kobject.c
> --- linux-2.6.10-rc1-mm4/lib/kobject.c~kobject_unregister_fix 2004-11-10 13:43:42.243877455 -0800
> +++ linux-2.6.10-rc1-mm4-askeshav/lib/kobject.c 2004-11-10 13:46:30.788797265 -0800
> @@ -301,6 +301,8 @@ void kobject_del(struct kobject * kobj)
> {
> kobject_hotplug(kobj, KOBJ_REMOVE);
> sysfs_remove_dir(kobj);
> +
> + /* unlink does kobject_put() for us */
> unlink(kobj);
> }
>
> @@ -313,7 +315,6 @@ void kobject_unregister(struct kobject *
> {
> pr_debug("kobject %s: unregistering\n",kobject_name(kobj));
> kobject_del(kobj);
> - kobject_put(kobj);
> }
No, this is wrong. Count the add and put in the sequence of:
kobject_register()
kobject_unregister()
they are balanced.
You mention you are seeing problems. Have a trace? Example code?
thanks,
gre k-h
-------------------------------------------------------
This SF.Net email is sponsored by:
Sybase ASE Linux Express Edition - download now for FREE
LinuxWorld Reader's Choice Award Winner for best database on Linux.
http://ads.osdn.com/?ad_idU88&alloc_id\x12065&op=click
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Keshavamurthy Anil S <anil.s.keshavamurthy@intel.com>
Cc: Hotplug List <linux-hotplug-devel@lists.sourceforge.net>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kobject: fix double kobject_put in kobject_unregister()
Date: Wed, 10 Nov 2004 14:54:21 -0800 [thread overview]
Message-ID: <20041110225421.GA16785@kroah.com> (raw)
In-Reply-To: <20041110141923.A13668@unix-os.sc.intel.com>
On Wed, Nov 10, 2004 at 02:19:23PM -0800, Keshavamurthy Anil S wrote:
> Hi Greg,
>
> This patch fixes the problem where in kobject resources were getting
> freed when those kobject were still in use due to double kobject_put()
> getting called in the kobject_unregister() code path.
>
> With out this patch kobject_unregister() will have some serious side effects.
>
> Please apply.
>
> signed-off-by: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>
>
>
> linux-2.6.10-rc1-mm4-askeshav/lib/kobject.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletion(-)
>
> diff -puN lib/kobject.c~kobject_unregister_fix lib/kobject.c
> --- linux-2.6.10-rc1-mm4/lib/kobject.c~kobject_unregister_fix 2004-11-10 13:43:42.243877455 -0800
> +++ linux-2.6.10-rc1-mm4-askeshav/lib/kobject.c 2004-11-10 13:46:30.788797265 -0800
> @@ -301,6 +301,8 @@ void kobject_del(struct kobject * kobj)
> {
> kobject_hotplug(kobj, KOBJ_REMOVE);
> sysfs_remove_dir(kobj);
> +
> + /* unlink does kobject_put() for us */
> unlink(kobj);
> }
>
> @@ -313,7 +315,6 @@ void kobject_unregister(struct kobject *
> {
> pr_debug("kobject %s: unregistering\n",kobject_name(kobj));
> kobject_del(kobj);
> - kobject_put(kobj);
> }
No, this is wrong. Count the add and put in the sequence of:
kobject_register()
kobject_unregister()
they are balanced.
You mention you are seeing problems. Have a trace? Example code?
thanks,
gre k-h
next prev parent reply other threads:[~2004-11-10 22:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-10 22:19 [PATCH] kobject: fix double kobject_put in kobject_unregister() Keshavamurthy Anil S
2004-11-10 22:19 ` Keshavamurthy Anil S
2004-11-10 22:30 ` Russell King
2004-11-10 22:30 ` Russell King
2004-11-10 22:39 ` Keshavamurthy Anil S
2004-11-10 22:39 ` Keshavamurthy Anil S
2004-11-10 22:54 ` Greg KH [this message]
2004-11-10 22:54 ` Greg KH
2004-11-10 23:04 ` Keshavamurthy Anil S
2004-11-10 23:04 ` Keshavamurthy Anil S
2004-11-11 2:03 ` Keiichiro Tokunaga
2004-11-11 2:03 ` Keiichiro Tokunaga
2004-11-11 1:54 ` Keshavamurthy Anil S
2004-11-11 1:54 ` Keshavamurthy Anil S
2004-11-11 1:54 ` Keshavamurthy Anil S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041110225421.GA16785@kroah.com \
--to=greg@kroah.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=linux-hotplug-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.