* [PATCH] include ordering breaks sysrq on 8250 serial
@ 2004-11-12 22:27 Matt Mackall
2004-11-12 22:34 ` Zwane Mwaikambo
0 siblings, 1 reply; 2+ messages in thread
From: Matt Mackall @ 2004-11-12 22:27 UTC (permalink / raw)
To: linux-kernel, Russell King, Andrew Morton
This has been pestering me for a couple days, finally dug into it:
serial_8250.h was including serial_core.h before SUPPORT_SYSRQ was
getting set up. I suspect this problem exists elsewhere. Tested
against latest bk snapshot.
Signed-off-by: Matt Mackall <mpm@selenic.com>
Index: l-bk20/drivers/serial/8250.c
===================================================================
--- l-bk20.orig/drivers/serial/8250.c Fri Nov 12 13:03:25 2004
+++ l-bk20/drivers/serial/8250.c Fri Nov 12 14:19:04 2004
@@ -20,6 +20,11 @@
* membase is an 'ioremapped' cookie.
*/
#include <linux/config.h>
+
+#if defined(CONFIG_SERIAL_8250_CONSOLE) && defined(CONFIG_MAGIC_SYSRQ)
+#define SUPPORT_SYSRQ
+#endif
+
#include <linux/module.h>
#include <linux/moduleparam.h>
#include <linux/tty.h>
@@ -37,10 +42,6 @@
#include <asm/io.h>
#include <asm/irq.h>
-#if defined(CONFIG_SERIAL_8250_CONSOLE) && defined(CONFIG_MAGIC_SYSRQ)
-#define SUPPORT_SYSRQ
-#endif
-
#include <linux/serial_core.h>
#include "8250.h"
--
Mathematics is the supreme nostalgia of our time.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] include ordering breaks sysrq on 8250 serial
2004-11-12 22:27 [PATCH] include ordering breaks sysrq on 8250 serial Matt Mackall
@ 2004-11-12 22:34 ` Zwane Mwaikambo
0 siblings, 0 replies; 2+ messages in thread
From: Zwane Mwaikambo @ 2004-11-12 22:34 UTC (permalink / raw)
To: Matt Mackall; +Cc: linux-kernel, Russell King, Andrew Morton
On Fri, 12 Nov 2004, Matt Mackall wrote:
> This has been pestering me for a couple days, finally dug into it:
>
> serial_8250.h was including serial_core.h before SUPPORT_SYSRQ was
> getting set up. I suspect this problem exists elsewhere. Tested
> against latest bk snapshot.
Thanks! I tried using it and thought perhaps i had finally conceded to the
little men in my head!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-11-12 22:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-11-12 22:27 [PATCH] include ordering breaks sysrq on 8250 serial Matt Mackall
2004-11-12 22:34 ` Zwane Mwaikambo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.