* [PATCH] Mark as_init and as_exit as init and exit functions
@ 2004-11-12 22:15 Chris Wright
2004-11-12 22:17 ` [PATCH] Mark cfq_exit as an exit function Chris Wright
2004-11-14 13:58 ` [PATCH] Mark as_init and as_exit " Jens Axboe
0 siblings, 2 replies; 4+ messages in thread
From: Chris Wright @ 2004-11-12 22:15 UTC (permalink / raw)
To: axboe; +Cc: linux-kernel
Mark as_init and as_exit as init and exit functions, and make them static.
Signed-off-by: Chris Wright <chris@osdl.org>
===== drivers/block/as-iosched.c 1.41 vs edited =====
--- 1.41/drivers/block/as-iosched.c 2004-10-19 02:40:18 -07:00
+++ edited/drivers/block/as-iosched.c 2004-10-29 16:28:05 -07:00
@@ -2096,7 +2096,7 @@ static struct elevator_type iosched_as =
.elevator_owner = THIS_MODULE,
};
-int as_init(void)
+static int __init as_init(void)
{
int ret;
@@ -2120,7 +2120,7 @@ int as_init(void)
return ret;
}
-void as_exit(void)
+static void __exit as_exit(void)
{
kmem_cache_destroy(arq_pool);
elv_unregister(&iosched_as);
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] Mark cfq_exit as an exit function
2004-11-12 22:15 [PATCH] Mark as_init and as_exit as init and exit functions Chris Wright
@ 2004-11-12 22:17 ` Chris Wright
2004-11-12 22:21 ` [PATCH] Mark deadline_init and deadline_exit as init and exit functions Chris Wright
2004-11-14 13:58 ` [PATCH] Mark as_init and as_exit " Jens Axboe
1 sibling, 1 reply; 4+ messages in thread
From: Chris Wright @ 2004-11-12 22:17 UTC (permalink / raw)
To: axboe; +Cc: linux-kernel
Mark cfq_exit function as and exit function, and make it static.
Signed-off-by: Chris Wright <chris@osdl.org>
cfq-iosched.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
===== drivers/block/cfq-iosched.c 1.12 vs edited =====
--- 1.12/drivers/block/cfq-iosched.c 2004-10-28 00:40:02 -07:00
+++ edited/drivers/block/cfq-iosched.c 2004-10-29 16:35:21 -07:00
@@ -1920,7 +1920,7 @@ int cfq_init(void)
return ret;
}
-void cfq_exit(void)
+static void __exit cfq_exit(void)
{
cfq_slab_kill();
elv_unregister(&iosched_cfq);
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] Mark deadline_init and deadline_exit as init and exit functions
2004-11-12 22:17 ` [PATCH] Mark cfq_exit as an exit function Chris Wright
@ 2004-11-12 22:21 ` Chris Wright
0 siblings, 0 replies; 4+ messages in thread
From: Chris Wright @ 2004-11-12 22:21 UTC (permalink / raw)
To: axboe; +Cc: linux-kernel
Mark deadline_init and deadline_exit as init and exit functions, and
make them static.
Signed-off-by: Chris Wright <chris@osdl.org>
===== drivers/block/deadline-iosched.c 1.31 vs edited =====
--- 1.31/drivers/block/deadline-iosched.c 2004-10-19 02:40:18 -07:00
+++ edited/drivers/block/deadline-iosched.c 2004-10-29 15:51:12 -07:00
@@ -936,7 +936,7 @@ static struct elevator_type iosched_dead
.elevator_owner = THIS_MODULE,
};
-int deadline_init(void)
+static int __init deadline_init(void)
{
int ret;
@@ -953,7 +953,7 @@ int deadline_init(void)
return ret;
}
-void deadline_exit(void)
+static void __exit deadline_exit(void)
{
kmem_cache_destroy(drq_pool);
elv_unregister(&iosched_deadline);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Mark as_init and as_exit as init and exit functions
2004-11-12 22:15 [PATCH] Mark as_init and as_exit as init and exit functions Chris Wright
2004-11-12 22:17 ` [PATCH] Mark cfq_exit as an exit function Chris Wright
@ 2004-11-14 13:58 ` Jens Axboe
1 sibling, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2004-11-14 13:58 UTC (permalink / raw)
To: Chris Wright; +Cc: linux-kernel
On Fri, Nov 12 2004, Chris Wright wrote:
> Mark as_init and as_exit as init and exit functions, and make them static.
Thanks (for all 3). This is an oversight from the recent modularization
of the io schedulers.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2004-11-14 13:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-11-12 22:15 [PATCH] Mark as_init and as_exit as init and exit functions Chris Wright
2004-11-12 22:17 ` [PATCH] Mark cfq_exit as an exit function Chris Wright
2004-11-12 22:21 ` [PATCH] Mark deadline_init and deadline_exit as init and exit functions Chris Wright
2004-11-14 13:58 ` [PATCH] Mark as_init and as_exit " Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.