* [2.6 patch] SCSI 53c700.c: make NCR_700_intr static
@ 2004-11-15 1:47 Adrian Bunk
0 siblings, 0 replies; 2+ messages in thread
From: Adrian Bunk @ 2004-11-15 1:47 UTC (permalink / raw)
To: James.Bottomley; +Cc: linux-scsi
NCR_700_intr is EXPORT_SYMBOL'e but has no external users.
Is the patch below correct or is future external usage planned?
diffstat output:
drivers/scsi/53c700.c | 4 ++--
drivers/scsi/53c700.h | 1 -
2 files changed, 2 insertions(+), 3 deletions(-)
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.10-rc1-mm5-full/drivers/scsi/53c700.h.old 2004-11-13 16:05:17.000000000 +0100
+++ linux-2.6.10-rc1-mm5-full/drivers/scsi/53c700.h 2004-11-13 16:19:50.000000000 +0100
@@ -63,7 +63,6 @@
struct NCR_700_Host_Parameters *, struct device *,
unsigned long, u8);
int NCR_700_release(struct Scsi_Host *host);
-irqreturn_t NCR_700_intr(int, void *, struct pt_regs *);
enum NCR_700_Host_State {
--- linux-2.6.10-rc1-mm5-full/drivers/scsi/53c700.c.old 2004-11-13 16:19:58.000000000 +0100
+++ linux-2.6.10-rc1-mm5-full/drivers/scsi/53c700.c 2004-11-13 16:22:42.000000000 +0100
@@ -167,6 +167,7 @@
#include "53c700_d.h"
+STATIC irqreturn_t NCR_700_intr(int irq, void *dev_id, struct pt_regs *regs);
STATIC int NCR_700_queuecommand(struct scsi_cmnd *, void (*done)(struct scsi_cmnd *));
STATIC int NCR_700_abort(struct scsi_cmnd * SCpnt);
STATIC int NCR_700_bus_reset(struct scsi_cmnd * SCpnt);
@@ -1486,7 +1487,7 @@
return 1;
}
-irqreturn_t
+STATIC irqreturn_t
NCR_700_intr(int irq, void *dev_id, struct pt_regs *regs)
{
struct Scsi_Host *host = (struct Scsi_Host *)dev_id;
@@ -2148,7 +2149,6 @@
EXPORT_SYMBOL(NCR_700_detect);
EXPORT_SYMBOL(NCR_700_release);
-EXPORT_SYMBOL(NCR_700_intr);
static struct spi_function_template NCR_700_transport_functions = {
.set_period = NCR_700_set_period,
^ permalink raw reply [flat|nested] 2+ messages in thread
* [2.6 patch] SCSI 53c700.c: make NCR_700_intr static
@ 2005-02-11 18:54 Adrian Bunk
0 siblings, 0 replies; 2+ messages in thread
From: Adrian Bunk @ 2005-02-11 18:54 UTC (permalink / raw)
To: Andrew Morton; +Cc: James.Bottomley, linux-scsi, linux-kernel
NCR_700_intr was EXPORT_SYMBOL'e but has no external users.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 15 Nov 2004
- 24 Nov 2004
drivers/scsi/53c700.c | 4 ++--
drivers/scsi/53c700.h | 1 -
2 files changed, 2 insertions(+), 3 deletions(-)
--- linux-2.6.10-rc1-mm5-full/drivers/scsi/53c700.h.old 2004-11-13 16:05:17.000000000 +0100
+++ linux-2.6.10-rc1-mm5-full/drivers/scsi/53c700.h 2004-11-13 16:19:50.000000000 +0100
@@ -63,7 +63,6 @@
struct NCR_700_Host_Parameters *, struct device *,
unsigned long, u8);
int NCR_700_release(struct Scsi_Host *host);
-irqreturn_t NCR_700_intr(int, void *, struct pt_regs *);
enum NCR_700_Host_State {
--- linux-2.6.10-rc1-mm5-full/drivers/scsi/53c700.c.old 2004-11-13 16:19:58.000000000 +0100
+++ linux-2.6.10-rc1-mm5-full/drivers/scsi/53c700.c 2004-11-13 16:22:42.000000000 +0100
@@ -167,6 +167,7 @@
#include "53c700_d.h"
+STATIC irqreturn_t NCR_700_intr(int irq, void *dev_id, struct pt_regs *regs);
STATIC int NCR_700_queuecommand(struct scsi_cmnd *, void (*done)(struct scsi_cmnd *));
STATIC int NCR_700_abort(struct scsi_cmnd * SCpnt);
STATIC int NCR_700_bus_reset(struct scsi_cmnd * SCpnt);
@@ -1486,7 +1487,7 @@
return 1;
}
-irqreturn_t
+STATIC irqreturn_t
NCR_700_intr(int irq, void *dev_id, struct pt_regs *regs)
{
struct Scsi_Host *host = (struct Scsi_Host *)dev_id;
@@ -2148,7 +2149,6 @@
EXPORT_SYMBOL(NCR_700_detect);
EXPORT_SYMBOL(NCR_700_release);
-EXPORT_SYMBOL(NCR_700_intr);
static struct spi_function_template NCR_700_transport_functions = {
.set_period = NCR_700_set_period,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-02-11 18:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-11-15 1:47 [2.6 patch] SCSI 53c700.c: make NCR_700_intr static Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2005-02-11 18:54 Adrian Bunk
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.