Re: Linux 2.6.10-rc2 SAVAGEFB startup crash

Re: Linux 2.6.10-rc2 SAVAGEFB startup crash

[Philipp Matthias Hahn]

Hello LKML!

2.6.10-rc2 on Debian i586 crashed during startup.

On Sun, Nov 14, 2004 at 06:49:04PM -0800, Linus Torvalds wrote:
> Summary of changes from v2.6.10-rc1 to v2.6.10-rc2
> ============================================
> Antonino Daplas:
...
>   o fbdev: S3 Savage Framebuffer Driver

Copied by hand:

show_stack+0x7f/0xa0
show_registers+0x156/0x1c0
die+0xc8/0x150
do_page_fault+0x326/0x6a2
error_code+0x2b/0x30
savagefb_create_i2c_busses+0x44/0xf0
savagefb_probe+0xe2/0x460
pci_device_probe_static+0x4d/0x60
__pci_device_probe+0x3c/0x50
pci_device_probe+0x2x/0x50
driver_probe_device+0x2e/0x80
driver_attach+0x5c/0xa0
bus_add_driver+0x95/0xd0
driver_register+0x31/0x40
pci_register_driver+0x64/0x80
savagefb_init+0x39/0x41
do_initcalls+0x2b/0xc0
init+0x28/0x110
kernel_thread_helper+0x5/0x10

(gdb) disassemble savagefb_create_i2c_busses
Dump of assembler code for function savagefb_create_i2c_busses:
0x02b0 <savagefb_create_i2c_busses+0>:  push %ebp
0x02b1 <savagefb_create_i2c_busses+1>:  mov  %esp,%ebp
0x02b3 <savagefb_create_i2c_busses+3>:  sub  $0x8,%esp
0x02b6 <savagefb_create_i2c_busses+6>:  mov  0x8(%ebp),%eax
0x02b9 <savagefb_create_i2c_busses+9>:  mov  0x234(%eax),%edx
0x02bf <savagefb_create_i2c_busses+15>: mov  %edx,0x8(%edx)
0x02c2 <savagefb_create_i2c_busses+18>: mov  0xe0(%eax),%eax
0x02c8 <savagefb_create_i2c_busses+24>: cmp  $0x88,%eax
0x02cd <savagefb_create_i2c_busses+29>: je   0x350 <savagefb_create_i2c_busses+160>
0x02d3 <savagefb_create_i2c_busses+35>: ja   0x340 <savagefb_create_i2c_busses+144>
0x02d5 <savagefb_create_i2c_busses+37>: add  $0xffffff80,%eax
0x02d8 <savagefb_create_i2c_busses+40>: je   0x2f8 <savagefb_create_i2c_busses+72>
0x02da <savagefb_create_i2c_busses+42>: lea  0x0(%esi),%esi
0x02e0 <savagefb_create_i2c_busses+48>: mov  $0x1,%eax
0x02e5 <savagefb_create_i2c_busses+53>: mov  %eax,0x4(%esp)
0x02e9 <savagefb_create_i2c_busses+57>: lea  0x8(%edx),%eax
0x02ec <savagefb_create_i2c_busses+60>: mov  %eax,(%esp)
0x02ef <savagefb_create_i2c_busses+63>: call 0x1c0 <savage_setup_i2c_bus>
0x02f4 <savagefb_create_i2c_busses+68>: mov  %ebp,%esp
0x02f6 <savagefb_create_i2c_busses+70>: pop  %ebp
0x02f7 <savagefb_create_i2c_busses+71>: ret

$ grep 'SAVAGE\|I2C' /boot/config-2.6.10-rc2
# I2C support
CONFIG_I2C=y
CONFIG_I2C_CHARDEV=m
# I2C Algorithms
CONFIG_I2C_ALGOBIT=y
CONFIG_I2C_ALGOPCF=m
CONFIG_I2C_ALGOPCA=m
# I2C Hardware Bus support
# CONFIG_I2C_ALI1535 is not set
# CONFIG_I2C_ALI1563 is not set
# CONFIG_I2C_ALI15X3 is not set
# CONFIG_I2C_AMD756 is not set
# CONFIG_I2C_AMD8111 is not set
CONFIG_I2C_ELEKTOR=m
# CONFIG_I2C_I801 is not set
# CONFIG_I2C_I810 is not set
CONFIG_I2C_ISA=m
# CONFIG_I2C_NFORCE2 is not set
CONFIG_I2C_PARPORT=m
CONFIG_I2C_PARPORT_LIGHT=m
CONFIG_I2C_PIIX4=m
CONFIG_I2C_PROSAVAGE=m
CONFIG_I2C_SAVAGE4=m
# CONFIG_I2C_SIS5595 is not set
# CONFIG_I2C_SIS630 is not set
# CONFIG_I2C_SIS96X is not set
# CONFIG_I2C_STUB is not set
# CONFIG_I2C_VIA is not set
# CONFIG_I2C_VIAPRO is not set
# CONFIG_I2C_VOODOO3 is not set
# CONFIG_I2C_PCA_ISA is not set
CONFIG_I2C_SENSOR=m
# Other I2C Chip support
# CONFIG_I2C_DEBUG_CORE is not set
# CONFIG_I2C_DEBUG_ALGO is not set
# CONFIG_I2C_DEBUG_BUS is not set
# CONFIG_I2C_DEBUG_CHIP is not set
CONFIG_FB_SAVAGE=y
CONFIG_FB_SAVAGE_I2C=y
CONFIG_FB_SAVAGE_ACCEL=y

BYtE
Philipp
-- 
/ /  (_)__  __ ____  __ Philipp Hahn
/ /__/ / _ \/ // /\ \/ /
/____/_/_//_/\_,_/ /_/\_\ pmhahn@titan.lahn.de

Re: Linux 2.6.10-rc2 SAVAGEFB startup crash

[Colin Leroy]

On 16 Nov 2004 at 08h11, Philipp Matthias Hahn wrote:

Hi, 

> savagefb_create_i2c_busses+0x44/0xf0

You can also try
gdb> list *savagefb_create_i2c_busses+0x44

to get the corresponding chunk of code if your kernel has CONFIG_DEBUG.
-- 
Colin

Re: Linux 2.6.10-rc2 SAVAGEFB startup crash

[Antonino A. Daplas]

On Tuesday 16 November 2004 15:55, Philipp Matthias Hahn wrote:
> Hello LKML!
>
> 2.6.10-rc2 on Debian i586 crashed during startup.
>
> On Sun, Nov 14, 2004 at 06:49:04PM -0800, Linus Torvalds wrote:
> > Summary of changes from v2.6.10-rc1 to v2.6.10-rc2
> > ============================================
> > Antonino Daplas:

Try rc1-mm5, rc2-mm1 or apply this particular changeset:

http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.10-rc1/2.6.10-rc1-mm5/broken-out/fbdev-allow-mode-change-even-if-edid-block-is-not-found.patch

Tony

Re: Linux 2.6.10-rc2 SAVAGEFB startup crash

[Philipp Matthias Hahn]

Hello Antonio, LKML!

On Tue, Nov 16, 2004 at 08:43:22PM +0800, Antonino A. Daplas wrote:
> On Tuesday 16 November 2004 15:55, Philipp Matthias Hahn wrote:
> > 2.6.10-rc2 on Debian i586 crashed during startup.
...
> Try rc1-mm5, rc2-mm1 or apply this particular changeset:
>
> http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.10-rc1/2.6.10-rc1-mm5/broken-out/fbdev-allow-mode-change-even-if-edid-block-is-not-found.patch

That fixed the crash, but the screen looks very broken on my notebook
after boot. Switching between XFree86 and SavageFB also locked up the
kernel hard.

BYtE
Philipp
-- 
  / /  (_)__  __ ____  __ Philipp Hahn
 / /__/ / _ \/ // /\ \/ /
/____/_/_//_/\_,_/ /_/\_\ pmhahn@titan.lahn.de

Re: Linux 2.6.10-rc2 SAVAGEFB startup crash

[Antonino A. Daplas]

On Wednesday 17 November 2004 01:27, Philipp Matthias Hahn wrote:
> Hello Antonio, LKML!
>
> On Tue, Nov 16, 2004 at 08:43:22PM +0800, Antonino A. Daplas wrote:
> > On Tuesday 16 November 2004 15:55, Philipp Matthias Hahn wrote:
> > > 2.6.10-rc2 on Debian i586 crashed during startup.
>
> ...
>
> > Try rc1-mm5, rc2-mm1 or apply this particular changeset:
> >
> > http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.10-rc1
> >/2.6.10-rc1-mm5/broken-out/fbdev-allow-mode-change-even-if-edid-block-is-n
> >ot-found.patch
>
> That fixed the crash, but the screen looks very broken on my notebook
> after boot. Switching between XFree86 and SavageFB also locked up the
> kernel hard.

Try booting at the native resolution of your notebook, for example:

video=savagefb:1024x768@60

Tony

Re: Linux 2.6.10-rc2 SAVAGEFB startup crash

[Antonino A. Daplas]

On Wednesday 17 November 2004 01:27, Philipp Matthias Hahn wrote:
> Hello Antonio, LKML!
>
> On Tue, Nov 16, 2004 at 08:43:22PM +0800, Antonino A. Daplas wrote:
> > On Tuesday 16 November 2004 15:55, Philipp Matthias Hahn wrote:

> after boot. Switching between XFree86 and SavageFB also locked up the

As for the lockup between X and the console, can you try this patch?

Tony

diff -Nru a/drivers/video/savage/savagefb.c b/drivers/video/savage/savagefb.c
--- a/drivers/video/savage/savagefb.c	2004-11-11 07:58:25 +08:00
+++ b/drivers/video/savage/savagefb.c	2004-11-17 05:40:47 +08:00
@@ -1797,23 +1797,23 @@
 	switch (info->fix.accel) {
 	case FB_ACCEL_SUPERSAVAGE:
 		par->chip = S3_SUPERSAVAGE;
-		snprintf (info->fix.id, 16, "S3 SuperSavage");
+		snprintf (info->fix.id, 16, "SuperSavage");
 		break;
 	case FB_ACCEL_SAVAGE4:
 		par->chip = S3_SAVAGE4;
-		snprintf (info->fix.id, 16, "S3 Savage4");
+		snprintf (info->fix.id, 16, "Savage4");
 		break;
 	case FB_ACCEL_SAVAGE3D:
 		par->chip = S3_SAVAGE3D;
-		snprintf (info->fix.id, 16, "S3 Savage3D");
+		snprintf (info->fix.id, 16, "Savage3D");
 		break;
 	case FB_ACCEL_SAVAGE3D_MV:
 		par->chip = S3_SAVAGE3D;
-		snprintf (info->fix.id, 16, "S3 Savage3D-MV");
+		snprintf (info->fix.id, 16, "Savage3D-MV");
 		break;
 	case FB_ACCEL_SAVAGE2000:
 		par->chip = S3_SAVAGE2000;
-		snprintf (info->fix.id, 16, "S3 Savage2000");
+		snprintf (info->fix.id, 16, "Savage2000");
 		break;
 	case FB_ACCEL_SAVAGE_MX_MV:
 		par->chip = S3_SAVAGE_MX;
@@ -1878,7 +1878,8 @@
 	info->fbops          = &savagefb_ops;
 	info->flags          = FBINFO_DEFAULT |
 		               FBINFO_HWACCEL_YPAN |
-		               FBINFO_HWACCEL_XPAN;
+		               FBINFO_HWACCEL_XPAN |
+	                       FBINFO_MISC_MODESWITCHLATE;
 
 	info->pseudo_palette = par->pseudo_palette;
 

Re: Linux 2.6.10-rc2 SAVAGEFB startup crash

[Philipp Matthias Hahn]

Hello!

On Wed, Nov 17, 2004 at 05:20:58AM +0800, Antonino A. Daplas wrote:
> > That fixed the crash, but the screen looks very broken on my notebook
> > after boot. Switching between XFree86 and SavageFB also locked up the
> > kernel hard.
>
> Try booting at the native resolution of your notebook, for example:
>
> video=savagefb:1024x768@60

The "@60" did it. (Reading "man 4x savage" -> "UseBIOS" gives my the
impression, that this is important for some mobile chips.)

On Wed, Nov 17, 2004 at 05:43:02AM +0800, Antonino A. Daplas wrote:
> > after boot. Switching between XFree86 and SavageFB also locked up the
>
> As for the lockup between X and the console, can you try this patch?
...
> -		               FBINFO_HWACCEL_XPAN;
> +		               FBINFO_HWACCEL_XPAN |
> +	                       FBINFO_MISC_MODESWITCHLATE;

That (partly) solved the lockup: I was able start XFree86, switch back
to Console, but on return to X11, the X11 screen wasn't restored
correctly, the mouse left a trail behind and switching to console
again didn't work. (a remove "chvt 1" as root still worked). Exiting
and than restarting XFree86 sometimes didn't initialize the screen
correctly.

While writing this email, my notebook locked up again hard and I had to
powercycle it.

BYtE
Philipp
-- 
  / /  (_)__  __ ____  __ Philipp Hahn
 / /__/ / _ \/ // /\ \/ /
/____/_/_//_/\_,_/ /_/\_\ pmhahn@titan.lahn.de

Re: Linux 2.6.10-rc2 SAVAGEFB startup crash

[Antonino A. Daplas]

--- Philipp Matthias Hahn <pmhahn@titan.lahn.de> wrote:

> Hello!
> 
> On Wed, Nov 17, 2004 at 05:20:58AM +0800, Antonino
> A. Daplas wrote:
> > -		               FBINFO_HWACCEL_XPAN;
> > +		               FBINFO_HWACCEL_XPAN |
> > +	                      
> FBINFO_MISC_MODESWITCHLATE;
> 
> That (partly) solved the lockup: I was able start
> XFree86, switch back
> to Console, but on return to X11, the X11 screen
> wasn't restored
> correctly, the mouse left a trail behind and
> switching to console

Try Option "UseBios" "False" in your /etc/X11/XF86Config, if at all possible.

Tony

Re: Linux 2.6.10-rc2 SAVAGEFB startup crash

[Philipp Matthias Hahn]

Hello LKML!

On Thu, Nov 18, 2004 at 06:35:32AM +0800, Antonino A. Daplas wrote:
> > On Wed, Nov 17, 2004 at 05:20:58AM +0800, Antonino
> > A. Daplas wrote:
> > > -		               FBINFO_HWACCEL_XPAN;
> > > +		               FBINFO_HWACCEL_XPAN |
> > > +	                       FBINFO_MISC_MODESWITCHLATE;
> >
> > That (partly) solved the lockup: I was able start XFree86, switch
> > back to Console, but on return to X11, the X11 screen wasn't
> > restored correctly, the mouse left a trail behind and switching to
> > console
>
> Try Option "UseBios" "False" in your /etc/X11/XF86Config, if at all possible.

FYI: That solved the problem, now savagefb and XFree86 are both running
fine. Thank you very much for your support.

BYtE
Philipp
-- 
  / /  (_)__  __ ____  __ Philipp Hahn
 / /__/ / _ \/ // /\ \/ /
/____/_/_//_/\_,_/ /_/\_\ pmhahn@titan.lahn.de