[KJ] Re: net/3c59x: module_param conversions

[KJ] Re: net/3c59x: module_param conversions

[Domen Puncer]

[-- Attachment #1: Type: text/plain, Size: 1027 bytes --]

On 18/11/04 14:19 +0100, Steffen Klassert wrote:
> On Tue, Nov 16, 2004 at 07:10:44PM +0100 or thereabouts, Domen Puncer wrote:
> > Convert 3c59x.c to new module parameter api.
> > Variables are moved before module_param*.
> 
> Just a remark,
> the module_param conversion for the 3c59x driver is already in the -mm tree.
> Many people route their patches through -mm, so it is in general a good 
> idea to look whats in -mm before starting to work.

Yeah, it's a good idea for popular conversions.

Anyway, in rc2-mm2:
--- linux-2.6.10-rc2/drivers/net/3c59x.c        2004-11-14 21:05:31.000000000 -0
800
+++ 25/drivers/net/3c59x.c      2004-11-17 23:21:24.184865960 -0800
@@ -277,6 +277,7 @@ MODULE_AUTHOR("Donald Becker <becker@scy
 MODULE_DESCRIPTION("3Com 3c59x/3c9xx ethernet driver "
                                        DRV_VERSION " " DRV_RELDATE);
 MODULE_LICENSE("GPL");
+MODULE_VERSION(DRV_VERSION);
 
 MODULE_PARM(debug, "i");
^^^
Doesn't seem converted.
Maybe you mean via-rhine patches; those are in.


	Domen

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] Re: net/3c59x: module_param conversions

[Steffen Klassert]

[-- Attachment #1: Type: text/plain, Size: 696 bytes --]

On Thu, Nov 18, 2004 at 03:22:33PM +0100 or thereabouts, Domen Puncer wrote:

> Anyway, in rc2-mm2:
> --- linux-2.6.10-rc2/drivers/net/3c59x.c        2004-11-14 21:05:31.000000000 -0
> 800
> +++ 25/drivers/net/3c59x.c      2004-11-17 23:21:24.184865960 -0800
> @@ -277,6 +277,7 @@ MODULE_AUTHOR("Donald Becker <becker@scy
>  MODULE_DESCRIPTION("3Com 3c59x/3c9xx ethernet driver "
>                                         DRV_VERSION " " DRV_RELDATE);
>  MODULE_LICENSE("GPL");
> +MODULE_VERSION(DRV_VERSION);
>  
>  MODULE_PARM(debug, "i");
> ^^^
> Doesn't seem converted.

Well, I was not up to date. The conversation was in  2.6.10-rc1-mm3 but
but backed out in -mm4 for some reason.

Steffen

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors