From: maximilian attems <janitor@sternwelten.at>
To: james4765@verizon.net
Cc: kernel-janitors@lists.osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [KJ] [PATCH] floppy: Reorganize drivers/block/floppy.c
Date: Fri, 19 Nov 2004 22:31:42 +0000 [thread overview]
Message-ID: <20041119223142.GJ2202@stro.at> (raw)
In-Reply-To: <20041105014000.11993.38553.30904@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 550 bytes --]
On Thu, 04 Nov 2004, james4765@verizon.net wrote:
> Organization of global variables, macros, and #defines in floppy.c
>
> Signed-off-by: James Nelson <james4765@gmail.com>
>
> diff -urN --exclude='*~' linux-2.6.9-original/drivers/block/floppy.c linux-2.6.9/drivers/block/floppy.c
> --- linux-2.6.9-original/drivers/block/floppy.c 2004-10-18 17:53:22.000000000 -0400
> +++ linux-2.6.9/drivers/block/floppy.c 2004-11-04 20:25:28.180478012 -0500
hmm could you split up your patch in logical hunks?
nitpicking: your patch adds whitespace.
a++ maks
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
WARNING: multiple messages have this Message-ID (diff)
From: maximilian attems <janitor@sternwelten.at>
To: james4765@verizon.net
Cc: kernel-janitors@lists.osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [KJ] [PATCH] floppy: Reorganize drivers/block/floppy.c
Date: Fri, 19 Nov 2004 23:31:42 +0100 [thread overview]
Message-ID: <20041119223142.GJ2202@stro.at> (raw)
In-Reply-To: <20041105014000.11993.38553.30904@localhost.localdomain>
On Thu, 04 Nov 2004, james4765@verizon.net wrote:
> Organization of global variables, macros, and #defines in floppy.c
>
> Signed-off-by: James Nelson <james4765@gmail.com>
>
> diff -urN --exclude='*~' linux-2.6.9-original/drivers/block/floppy.c linux-2.6.9/drivers/block/floppy.c
> --- linux-2.6.9-original/drivers/block/floppy.c 2004-10-18 17:53:22.000000000 -0400
> +++ linux-2.6.9/drivers/block/floppy.c 2004-11-04 20:25:28.180478012 -0500
hmm could you split up your patch in logical hunks?
nitpicking: your patch adds whitespace.
a++ maks
next prev parent reply other threads:[~2004-11-19 22:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-05 1:40 [KJ] [PATCH] floppy: Reorganize drivers/block/floppy.c james4765
2004-11-05 1:40 ` james4765
2004-11-19 22:31 ` maximilian attems [this message]
2004-11-19 22:31 ` [KJ] " maximilian attems
2004-11-20 4:33 ` Jim Nelson
2004-11-20 4:33 ` Jim Nelson
2004-11-20 8:49 ` maximilian attems
2004-11-20 8:49 ` maximilian attems
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041119223142.GJ2202@stro.at \
--to=janitor@sternwelten.at \
--cc=james4765@verizon.net \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.