* [Ocfs2-devel] Re: [Ocfs2-commits] mfasheh commits r1663 - branches/dlm-glue/src [not found] <200411230337.iAN3bJSS015490@oss.oracle.com> @ 2004-11-23 2:31 ` Christoph Hellwig 2004-11-23 2:58 ` Mark Fasheh 0 siblings, 1 reply; 3+ messages in thread From: Christoph Hellwig @ 2004-11-23 2:31 UTC (permalink / raw) To: ocfs2-devel On Mon, Nov 22, 2004 at 09:37:19PM -0600, svn-commits@oss.oracle.com wrote: > Author: mfasheh > Date: 2004-11-22 21:37:18 -0600 (Mon, 22 Nov 2004) > New Revision: 1663 > > Modified: > branches/dlm-glue/src/journal.c > branches/dlm-glue/src/namei.c > branches/dlm-glue/src/ocfs.h > branches/dlm-glue/src/super.c > Log: > * ocfs_malloc was hardly used so lets take this opportunity to get rid of it. You never opencode the memset ocfs_malloc did. Did you do an audit that it's never needed? ^ permalink raw reply [flat|nested] 3+ messages in thread
* [Ocfs2-devel] Re: [Ocfs2-commits] mfasheh commits r1663 - branches/dlm-glue/src 2004-11-23 2:31 ` [Ocfs2-devel] Re: [Ocfs2-commits] mfasheh commits r1663 - branches/dlm-glue/src Christoph Hellwig @ 2004-11-23 2:58 ` Mark Fasheh 2004-11-23 3:04 ` Christoph Hellwig 0 siblings, 1 reply; 3+ messages in thread From: Mark Fasheh @ 2004-11-23 2:58 UTC (permalink / raw) To: ocfs2-devel On Tue, Nov 23, 2004 at 09:30:52AM +0100, Christoph Hellwig wrote: > You never opencode the memset ocfs_malloc did. Did you do an audit that > it's never needed? Yeah, stupidly, much of the code which called ocfs_malloc did the memset anyway so that's why you don't see any "+ memset( ..." lines in the patch :) --Mark -- Mark Fasheh Software Developer, Oracle Corp mark.fasheh@oracle.com ^ permalink raw reply [flat|nested] 3+ messages in thread
* [Ocfs2-devel] Re: [Ocfs2-commits] mfasheh commits r1663 - branches/dlm-glue/src 2004-11-23 2:58 ` Mark Fasheh @ 2004-11-23 3:04 ` Christoph Hellwig 0 siblings, 0 replies; 3+ messages in thread From: Christoph Hellwig @ 2004-11-23 3:04 UTC (permalink / raw) To: ocfs2-devel On Tue, Nov 23, 2004 at 12:58:53AM -0800, Mark Fasheh wrote: > On Tue, Nov 23, 2004 at 09:30:52AM +0100, Christoph Hellwig wrote: > > You never opencode the memset ocfs_malloc did. Did you do an audit that > > it's never needed? > Yeah, stupidly, much of the code which called ocfs_malloc did the memset > anyway so that's why you don't see any "+ memset( ..." lines in the patch :) ok ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-11-23 3:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200411230337.iAN3bJSS015490@oss.oracle.com>
2004-11-23 2:31 ` [Ocfs2-devel] Re: [Ocfs2-commits] mfasheh commits r1663 - branches/dlm-glue/src Christoph Hellwig
2004-11-23 2:58 ` Mark Fasheh
2004-11-23 3:04 ` Christoph Hellwig
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.