From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Nikita Danilov <nikita@clusterfs.com>,
Linux-Kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH]: 1/4 batch mark_page_accessed()
Date: Wed, 24 Nov 2004 08:40:20 -0200 [thread overview]
Message-ID: <20041124104020.GA9777@logos.cnet> (raw)
In-Reply-To: <20041121131250.26d2724d.akpm@osdl.org>
On Sun, Nov 21, 2004 at 01:12:50PM -0800, Andrew Morton wrote:
> Nikita Danilov <nikita@clusterfs.com> wrote:
> >
> > Batch mark_page_accessed() (a la lru_cache_add() and lru_cache_add_active()):
> > page to be marked accessed is placed into per-cpu pagevec
> > (page_accessed_pvec). When pagevec is filled up, all pages are processed in a
> > batch.
> >
> > This is supposed to decrease contention on zone->lru_lock.
>
> Looks sane, althought it does add more atomic ops (the extra
> get_page/put_page). Some benchmarks would be nice to have.
I'll run STP benchmarks as soon as STP is working again.
WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Nikita Danilov <nikita@clusterfs.com>,
Linux-Kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH]: 1/4 batch mark_page_accessed()
Date: Wed, 24 Nov 2004 08:40:20 -0200 [thread overview]
Message-ID: <20041124104020.GA9777@logos.cnet> (raw)
In-Reply-To: <20041121131250.26d2724d.akpm@osdl.org>
On Sun, Nov 21, 2004 at 01:12:50PM -0800, Andrew Morton wrote:
> Nikita Danilov <nikita@clusterfs.com> wrote:
> >
> > Batch mark_page_accessed() (a la lru_cache_add() and lru_cache_add_active()):
> > page to be marked accessed is placed into per-cpu pagevec
> > (page_accessed_pvec). When pagevec is filled up, all pages are processed in a
> > batch.
> >
> > This is supposed to decrease contention on zone->lru_lock.
>
> Looks sane, althought it does add more atomic ops (the extra
> get_page/put_page). Some benchmarks would be nice to have.
I'll run STP benchmarks as soon as STP is working again.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2004-11-24 15:34 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-21 15:44 [PATCH]: 1/4 batch mark_page_accessed() Nikita Danilov
2004-11-21 15:44 ` Nikita Danilov
2004-11-21 21:12 ` Andrew Morton
2004-11-21 21:12 ` Andrew Morton
2004-11-24 10:40 ` Marcelo Tosatti [this message]
2004-11-24 10:40 ` Marcelo Tosatti
2004-11-24 16:32 ` Marcelo Tosatti
2004-11-24 16:32 ` Marcelo Tosatti
2004-11-24 21:53 ` Nikita Danilov
2004-11-24 21:53 ` Nikita Danilov
2004-11-26 18:58 ` Marcelo Tosatti
2004-11-26 18:58 ` Marcelo Tosatti
2004-11-27 0:37 ` Nick Piggin
2004-11-27 0:37 ` Nick Piggin
2004-11-30 16:29 ` Marcelo Tosatti
2004-11-30 16:29 ` Marcelo Tosatti
2004-12-01 1:33 ` Andrew Morton
2004-12-01 1:33 ` Andrew Morton
2004-11-30 22:57 ` Marcelo Tosatti
2004-11-30 22:57 ` Marcelo Tosatti
2004-12-01 12:23 ` Nikita Danilov
2004-12-01 12:23 ` Nikita Danilov
2004-12-01 18:58 ` Marcelo Tosatti
2004-12-01 18:58 ` Marcelo Tosatti
2004-12-02 1:59 ` Andrew Morton
2004-12-02 1:59 ` Andrew Morton
2004-11-27 10:41 ` Nikita Danilov
2004-11-27 10:41 ` Nikita Danilov
2004-11-27 8:19 ` Marcelo Tosatti
2004-11-27 8:19 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041124104020.GA9777@logos.cnet \
--to=marcelo.tosatti@cyclades.com \
--cc=Linux-Kernel@vger.kernel.org \
--cc=akpm@osdl.org \
--cc=linux-mm@kvack.org \
--cc=nikita@clusterfs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.